NSIS installer crashes when provisioning file is added

[tresf]

This bug is reproducible with #1190 (provision branch checked out exactly 80a71ea) calling the following:

ant -Dprovision.file=./test/qz/installer/provision/resources/provision.json nsis

• Install the produced .exe on Windows, the installer crashes
• Make NSIS 3.0.8
• Building on Mac M1
• Bug goes away if the provisioning file is removed

The issue has temporarily gone away with this commit: 38e41b1. My current theory is that there's a bug with nsExec::ExecToLog: https://github.com/qzind/tray/blob/3c0ab9495b74ec440cd8faf78b8bdc81ef155ad4/ant/windows/windows-installer.nsi.in#L42

Upstream bug report: https://sourceforge.net/p/nsis/bugs/1301/

[tresf]

Closed via 2f7fe3a. Our envp variable was MUCH MUCH longer than the maximum NSIS string length and it was causing random crashes. The issue surfaced with #1190 because it performs additional shell commands which echo this to the terminal.

Filed a bug upstream with NSIS team: https://sourceforge.net/p/nsis/bugs/1301/