macOS: Fix HID crashing regression - Githubissues

qzind / tray

Browser plugin for sending documents and raw commands to a printer or attached device.

https://qz.io

Other

823 stars 266 forks source link

macOS: Fix HID crashing regression #1267

Open Vzor- opened 4 weeks ago

Vzor- commented 4 weeks ago

QZ Tray 2.2.3 reintroduced a regression similar to https://github.com/qzind/tray/issues/137 likely introduced with https://github.com/qzind/tray/pull/1177.

Background

https://github.com/libusb/hidapi/issues/45
https://github.com/libusb/hidapi/issues/666
The improved threading in #1177 appears to have re-exposed #137 and likely the cause for #1265

This patch is based solely off of the (at time of writing this) unmerged:

https://github.com/gary-rowe/hid4java/pull/153

It adds some sane same-thread handling to otherwise unwieldy HID calls from our software.

Closes #137 Closes #1265