qzind / tray

Browser plugin for sending documents and raw commands to a printer or attached device.
https://qz.io
Other
848 stars 276 forks source link

DYMO Twin Turbo - Left & Right Roll not working for HTML printing (Windows) #759

Closed amuhtar closed 3 years ago

amuhtar commented 3 years ago

Using the Demo page, if I connect to a DYMO LabelWriter 450 Twin Turbo, regardless of the tray selected ("left roll" or "right roll"), the printer will only print to the last one used.

This is not the case with the Image or PDF print.

On the demo page

tresf commented 3 years ago

@amuhtar thanks kindly for the detailed testing. We'll attempt to reproduce and escalate accordingly.

@bberenz I'm thinking we can start troubleshooting around here: https://github.com/qzind/tray/blob/97ac82699f691adc115f40d534afd80bcf2e03cb/src/qz/printer/action/PrintHTML.java#L191-L194

tresf commented 3 years ago

@amuhtar at a glance it appears the code could benefit from adopting some of our AWT tray selection that we use elsewhere.

https://github.com/qzind/tray/blob/4bed8e38b7eeab08bbae8cc8485c0129a167f92d/src/qz/printer/action/PrintPixel.java#L47-L77

Currently, JavaFX requires a dead-on match, This means "Roll" would not match "roll". We'll continue our investigation.

amuhtar commented 3 years ago

Ok... I didn't realize the precise tray names were "Left Roll" and "Right Roll".
Thanks! Most of the options seem to be lower case.

tresf commented 3 years ago

We rewrote the Tray match behavior for HTML to be the same as Images and PDFs, so this should be working as expected now. Please request a reopen if this issue persists. This fix will be available starting with QZ Tray 2.1.3. If you need a build prior, email support@qz.io. 🍻

amuhtar commented 3 years ago

Thank you. I appreciate all the work and effort you and your team have done to make QZ as good as it is!

Andrew

On Mar 4, 2021, at 11:10 AM, Tres Finocchiaro notifications@github.com wrote:

We rewrote the Tray match behavior for HTML to be the same as Images and PDFs, so this should be working as expected now. Please request a reopen if this issue persists. This fix will be available starting with QZ Tray 2.1.3. If you need a build prior, email support@qz.io mailto:support@qz.io. 🍻

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/qzind/tray/issues/759#issuecomment-790732074, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH2AQ2KYS4CUPSUNLZ2C2TTB6WIFANCNFSM4YCQZEYQ.