search

r-a-y / bp-reply-by-email

Reply to BuddyPress items from the comfort of your email inbox. Currently in pre-release.
GNU General Public License v2.0
63 stars 9 forks source link

Missing string from translation file #108

Closed modelm closed 6 years ago

modelm commented 6 years ago

I would like to translate the following string found in https://github.com/r-a-y/bp-reply-by-email/blob/master/includes/bp-rbe-functions.php#L317:

__( '--- Replying to this email will not send a message directly to the recipient or group ---', 'bp-rbe' )

It's not in https://github.com/r-a-y/bp-reply-by-email/blob/master/languages/bp-rbe.pot.

r-a-y commented 6 years ago

Thanks for opening. I know I don't update the POT file as often as I should.

I'll probably update it once I've added SparkPost support to attachments (#104).

In the meantime, you can also use the 'bp_rbe_get_nonrbe_notice' filter to override that string.

modelm commented 6 years ago

Sounds good, I went ahead and generated a temporary current POT file from the latest master in case anybody needs it: https://gist.github.com/modelm/b2409848b8ba082f00005ceaf8a83f34

modelm commented 6 years ago

Using my translation file to translate this particular string, I found there is a character limit that breaks replying because of a line break preventing the string matching (I think). When it's long enough to break a line, I get a "Your Reply By Email message could not be posted" error back and this is the quoted message:

Your reply could not be posted because we could not find the "--- Reply to this e-mail to send your response to the Commons (attachments coming soon!) ---" marker in the body of your email.

In the future, please make sure you reply *above* this line for your comment to be posted on the site.

For reference, your entire reply was:

"Replying by email!

On Mon, Dec 18, 2017 at 1:55 PM, Ryan Williams 
wrote:

> --- Reply to this e-mail to send your response to the Commons (attachments
> coming soon!) ---
>

I'm not sure if this affects only certain email clients (I only tested Gmail) or what actually causes the line break. Seems like it's breaking whole words at 80 characters. If I shorten the translation so that it doesn't break a line, replying works fine.

r-a-y commented 6 years ago

The main issue is fixed in #112.

The other issue mentioned in the last comment is tracked in #109.