search

r-a-y / buddypress-followers

Follow users on your BuddyPress site. Similar to Twitter!
http://wordpress.org/plugins/buddypress-followers/
74 stars 39 forks source link

WPCS Fixes for BuddyPress Followers #93

Closed renatonascalves closed 6 years ago

renatonascalves commented 6 years ago

I have a local, modified, version of BuddyPress Followers. While updating my version with the recent changes from BF, I noticed several WPCS bugs.

This PR tries to fix most of them.

r-a-y commented 6 years ago

Looks good! But can you change all instances of buddypress() to $GLOBALS['bp'] instead? BP Follow still supports v1.2 (for better or worse!).

Not sure if that will fix the use of global variables with WPCS though.

Thanks @renatonascalves!

renatonascalves commented 6 years ago

@r-a-y About the global change, not a problem! Makes total sense!

renatonascalves commented 6 years ago

@r-a-y Do you need more updates or changes?

r-a-y commented 6 years ago

@renatonascalves - Appreciate the PR. I'll take a look when I can and will report back.

r-a-y commented 6 years ago

I've merged this. If there are issues, one of us should hopefully catch some bugs and fix them :)

Thanks @renatonascalves !

renatonascalves commented 6 years ago

Great! @r-a-y I have a site running with the WPCS changes without issues. But if something comes up, count on me to debug and fix. :)