search

r-almendarez / dpam-vif-generator

DPAM VIF Generator generates a USBIF/DPAM VIF file based on user inputs for use with test equipment correlation, proper test coverage for certification, and at VESA Plugtest events.
MIT License
4 stars 2 forks source link

SOPP_DisplayPort_Capabilities, DP_Signaling_Rate does not follow VIF Spec. #10

Open bleungatchromium opened 3 months ago

bleungatchromium commented 3 months ago

From DPAM_VIF_Spec_Rev0p2.docx:

SOP’ DisplayPort Capabilities (USB PD Discover Modes for 0xFF01) SOPP_DP_Signaling_Rate This field corresponds to the rates supported by the cable.

Setting Value
HBR3 0001b
HBR3 & UHBR10 0011b
HBR3 & UHBR10 & UHBR20 0111b

Since the UI uses a dropdown menu here, by default it's a 0 indexed enum, which doesn't comply with the VIF spec (and therefore the DPAM 2.1 spec), as the speed values must set 1 and then all values lower. (so the allowed enumerated values are in decimal, 1, 3, 7).

bleungatchromium commented 3 months ago

Here's an example snippet from the xml generated by the vif tool.

     <opt:SOPP_DisplayPort_Capabilities>                                       
        <opt:DP_Signaling_Rate value="2">HBR3, UHBR10, &amp; UHBR20</opt:DP_Signaling_Rate>

The value of 2 is incorrect, and is meaningless for the folks following the VIF spec.

bleungatchromium commented 3 months ago

@TimWei888 and @r-almendarez as a fyi as well.

I found another instance where if cable SOPP is described, we are not consistent with the posted spec.

TimWei888 commented 3 months ago

I agree. I forgot this one.

@TimWei888 and @r-almendarez as a fyi as well.

I found another instance where if cable SOPP is described, we are not consistent with the posted spec.

bleungatchromium commented 3 months ago

I'll figure out how to add a custom handler for dropdown elements for this one, as a group box doesn't make sense for this.