search

r-barnes / Barnes2019-DepressionHierarchy

Fast handling of depressions in flow graphs
MIT License
9 stars 7 forks source link

Ocean <= <Ocean Level> #12

Closed awickert closed 3 years ago

KCallaghan commented 4 years ago

I think a potential issue with this is that one wouldn't necessarily want cells lower than the defined ocean_level to be considered as ocean (e.g. Death Valley is below sea level but should not be considered ocean). Perhaps the nomenclature 'ocean_level' is a problem when we really mean 'what is the value in your input DEM for cells that are ocean?'.

awickert commented 3 years ago

Good point @KCallaghan. I have addressed this in a new PR and am closing this one.