search

r-barnes / faster-unmixer

A faster implementation of the sediment inverse/unmixing scheme proposed in Lipp et al (2021).
5 stars 1 forks source link

Add missing DefaultDict import and regularizer_strength definition #22

Closed AlexLipp closed 1 year ago

AlexLipp commented 1 year ago

Couple errors have crept into main branch, from recent merges:

  1. DefaultDict import statement is missing in geochem_inverse_optimize
  2. DefaultDict used erroneously as defaultdict
  3. regularizer_strength not defined in unmix.py.

This PR fixes the above.

r-barnes commented 1 year ago

Good catch, but DefaultDict is for indicating types, not making a defaultdict. I've made the changes you've suggested here in ed718c0c38b92b7549b7f085da31051ee1598f83 and pushed directly to master.