search

r-barnes / faster-unmixer

A faster implementation of the sediment inverse/unmixing scheme proposed in Lipp et al (2021).
6 stars 1 forks source link

Remove references to `sample_adjacency` #34

Closed AlexLipp closed 1 year ago

AlexLipp commented 1 year ago

SampleNetwork still includes reference to sample_adjacency that was being used in old method for regularising the solution. These should be removed from python script, and potentially the C++ too?

AlexLipp commented 1 year ago

Relatedly, I'm not sure that SampleNetwork is actually the right name for the unmixing class. Perhaps NetworkUnmixer is more appropriate?

AlexLipp commented 1 year ago

These are addressed in #38