search

r-bioinformatics / edgePy

A Python implementation of edgeR for differential expression analysis
https://edgepy.readthedocs.io
MIT License
96 stars 10 forks source link

Update tox to python 3.7 #74

Closed moritzschaefer closed 6 years ago

moritzschaefer commented 6 years ago

It's been a few months since Python received a minor version upgrade (3.7). As it is (of course) downwards compatible and it should be encouraged to use up to date software, I would suggest to use python 3.7 as default interpreter in tox.

veena-v-g commented 6 years ago

@moritzschaefer Are you working on this issue? Would you be okay if I jumped in?

moritzschaefer commented 6 years ago

Hey @vghorakavi. In my opinion this is just political: I'm working on my computer with 3.7 exclusively. I changed the tox file to use 3.7 instead of 3.6 and everything works fine.

veena-v-g commented 6 years ago

@moritzschaefer Hey! Thanks for letting me know. Want to jump back into the project after making a small change. I will let you continue.

clintval commented 6 years ago

There are backwards incompatible features in 3.7. to ensure we remain Py3.6+ you'll actually have to run testing under both Python interpreter versions.

TravisCI can be configured with Tox to also run a matrix of interpreters.

My bid: do not drop Py3.6 testing.

apfejes commented 6 years ago

I agree with clintval - lets not force this move just yet.