Open GoogleCodeExporter opened 9 years ago
I think a fixed verse range would be much easier to implement.
Having a spin control to choose a number of verses of context could do this.
Also needed in search panel.
Original comment by benpmor...@gmail.com
on 6 Jul 2008 at 10:25
It would certainly be easier to implement. I think the other would be
preferable if
it can be implemented, but having something is a good start.
I can't see a spin control working well on the tooltip, though if it was
somewhere in
the options with a good default it would be perfectly acceptable.
If you are making it a fixed number of verses, the button should be able to be
used
multiple times.
Original comment by jonmmor...@gmail.com
on 6 Jul 2008 at 10:51
I'm confused...if we click the link to the verse, we get the full context. Why
need a
button or something extra? This only makes sense to me if it just expands
references
by whatever amount of context in the actual tooltip (e.g., with a context of 1
verse
before and 1 verse after, a reference like "Ezra.1.8" gets expanded to
"Ezra.1.7-Ezra.1.9" and all three verses get displayed in the tooltip).
Given that understanding, here is a quick & dirty patch (against r129) to add a
context of one verse prior and after. It doesn't do any bounds checking, so it's
somewhat broken for verses that start before or extend beyond the current
chapter's
verse range, but it's just a proof-of-concept.
Original comment by MonkeeS...@gmail.com
on 22 Jul 2008 at 3:31
Attachments:
The idea is to put it in the tooltip (and search window) so the user doesn't
have to
change to a different passage. Ideally, the context would be found by looking at
paragraph breaks; for now a configurable number of verses will be used when it
is
implemented. Also, the actual reference should be in a different colour, so as
to
distinguish it from the context.
The SWORD library makes it reasonably easy to get the context of a passage;
this is
less error-prone than parsing with regular expressions.
Original comment by benpmor...@gmail.com
on 22 Jul 2008 at 5:29
Ah, I see. I'm not familiar with the sword API at all (on my TODO list); I just
recently started using bpbible. Previously I had been using gnomesword, and
developing my own Bible program using sqlite as a backend (fairly mature, not
to pat
myself on the back). I just decided it was better not to reinvent the wheel,
and was
extremely impressed with bpbible. :) Keep up the good work.
Original comment by MonkeeS...@gmail.com
on 22 Jul 2008 at 5:37
Removing 0.4 milestone, since this is not high enough priority.
Original comment by jonmmor...@gmail.com
on 6 Nov 2008 at 1:54
Original issue reported on code.google.com by
jonmmor...@gmail.com
on 13 May 2008 at 10:56