search

r-causal / causal-inference-in-R

Causal Inference in R: A book!
https://www.r-causal.org/
190 stars 49 forks source link

use new column name in love plot #148

Closed simonpcouch closed 1 year ago

simonpcouch commented 1 year ago

Thanks for the wonderful work, yall.🍄

When rendering Ch. 2, I was seeing the following error:

Quitting from lines 487-507 (chapter-02.qmd) 
Error in `ggplot2::geom_line()`:
! Problem while computing aesthetics.
ℹ Error occurred in the 2nd layer.
Caused by error in `compute_aesthetics()`:
! Aesthetics are not valid data columns.
✖ The following aesthetics are invalid:
✖ `group = NULL`
✖ `colour = NULL`
ℹ Did you mistype the name of a data column or forget
  to add `after_stat()`?

It looks like this was because those two aesthetics were set to a column name that has since been changed in tidysmd. By default, dependencies resolved to use dev tidysmd—I think this is because it's a second-order dependency via halfmoon, which references the GitHub version. This PR follows the lead of https://github.com/malcolmbarrett/halfmoon/commit/e6152708d725bbf8f071d505560745612ede352a and updates those column names. :)

malcolmbarrett commented 1 year ago

Thank you!

malcolmbarrett commented 1 year ago

And yes, giving these tools a bit of attention after letting them marinate, so there may be some more breaking changes