r-causal / causal-inference-in-R

Causal Inference in R: A book!
https://www.r-causal.org/
169 stars 42 forks source link

Update sentence diagrams to figma versions #179

Closed malcolmbarrett closed 10 months ago

malcolmbarrett commented 10 months ago

@LucyMcGowan what do you think about this tweak to the sentence diagrams? I started updating the ggplot versions but found them a bit fragile. I made these on figma so I can share that with you if you like them

LucyMcGowan commented 10 months ago

I am on the fence I totally agree that ggplot is not a good option but I want to do something that we can code in instead of hard coding in pngs that we have to update by hand

malcolmbarrett commented 10 months ago

That would be ideal, but for what it's worth, I managed to do this pretty quickly, and Figma is pretty good about having files accessible

malcolmbarrett commented 10 months ago

Maybe we should just cross that bridge when we come to it, e.g. merge this and if we find ourselves needing to update it, we find another code-based option (or at least something less manual)

LucyMcGowan commented 10 months ago

ok! the issue for me is when I am using the material to make slides it is less of a pain for me to copy the bad ggplot code into a slide than to have to figure out where the file is and copy it in but this might just be a personal preference! I am fine with merging this though 😂

malcolmbarrett commented 10 months ago

Hm one solution to that is to use the URL to the image on the rendered book directly in the slides so that they'll keep in sync whenever it's modified in the book. Then you don't need to manage a second+ file

malcolmbarrett commented 10 months ago

I'm going to merge but if we find a better solution happy to switch!

LucyMcGowan commented 10 months ago

See this is why we need you, just linking the url is brilliant!!