Enhancement: Let sleeping dogs lie

r-cochran / cuke_sniffer

A ruby library used to root out smells in your cukes.

MIT License

44 stars 28 forks source link

Enhancement: Let sleeping dogs lie #34

Closed enkessler closed 11 years ago

enkessler commented 11 years ago

Empty improvement categories (e.g. 'Hooks' when there are no hooks triggering rules) still have the +/- toggle and can be expanded/colapsed. Perhaps make this not be the case?

vaughncm commented 11 years ago

I'm defining this as both a bug and enhancement. This is an improvement that I believe we want to make as part of the HTML overhaul. Thanks for the feedback.

r-cochran commented 11 years ago

This was a miss on my part. I had added code for the case of there being no objects of a given type to display a message in the expanded section. My condition was against the total of objects in the list instead of the displayable objects. Will be a quick fix. I agree with @vaughncm 's labels of bug/enhancement.

r-cochran commented 11 years ago

In the next release there will be a message describing that there were no objects of a type to be evaluated. Example: "Excellent! No smells found for Hooks!".