search

r-darwish / alma

Create Arch Linux based bootable USB drives
GNU General Public License v3.0
389 stars 31 forks source link

locale config step bevore running scripts #58

Closed bornf closed 3 years ago

bornf commented 3 years ago

setting up a different locale in a script gets overwritten by the hardcoded locale

jamesmcm commented 3 years ago

This is just because of the current order of operations:

The locale is set after running scripts:

Running scripts L342: https://github.com/r-darwish/alma/blob/dcdce6f079113841d6ad7ec9d99395679a6274b4/src/main.rs#L342

Setting locale L409: https://github.com/r-darwish/alma/blob/dcdce6f079113841d6ad7ec9d99395679a6274b4/src/main.rs#L409

I think we can just move the setting the locale before the scripts, this shouldn't break anything. I'll do a quick test now and make a PR.

bornf commented 3 years ago

great, thanks...