r-darwish / topgrade

Upgrade everything
GNU General Public License v3.0
3.35k stars 160 forks source link

Doom Emacs upgrade stopped working #1015

Closed raszi closed 2 years ago

raszi commented 2 years ago

What did you expect to happen?

The Doom Emacs gets upgraded.

What actually happened?

Doom Emacs does not get updated.

Additional Details

➜  ~ topgrade -v --only emacs         
 2022-09-22T09:57:22.273Z DEBUG topgrade::config > Configuration at /Users/ikaraszi/.config/topgrade.toml
 2022-09-22T09:57:22.274Z DEBUG topgrade::config > Loaded configuration: ConfigFile { pre_commands: Some({}), post_commands: None, commands: Some({}), git_repos: None, predefined_git_repos: None, disable: Some([Gem, Pip3, System, GithubCliExtensions]), ignore_failures: None, remote_topgrades: None, remote_topgrade_path: None, ssh_arguments: None, git_arguments: None, tmux_arguments: None, set_title: None, display_time: None, assume_yes: None, yay_arguments: None, no_retry: None, run_in_tmux: None, cleanup: None, notify_each_step: None, accept_all_windows_updates: None, bashit_branch: None, only: None, composer: Some(Composer { self_update: None }), brew: Some(Brew { greedy_cask: None }), linux: Some(Linux { yay_arguments: None, arch_package_manager: None, show_arch_news: None, trizen_arguments: None, pikaur_arguments: None, dnf_arguments: None, apt_arguments: None, enable_tlmgr: None, redhat_distro_sync: None, rpm_ostree: None, emerge_sync_flags: None, emerge_update_flags: None }), git: Some(Git { max_concurrency: None, arguments: None, repos: None, pull_predefined: None }), windows: Some(Windows { accept_all_updates: None, self_rename: None, open_remotes_in_new_terminal: None, enable_winget: None }), npm: Some(NPM { use_sudo: None }), vim: None, firmware: Some(Firmware { upgrade: None }), vagrant: None, flatpak: Some(Flatpak { use_sudo: None }) }
 2022-09-22T09:57:22.274Z DEBUG topgrade         > Version: 9.0.1
 2022-09-22T09:57:22.274Z DEBUG topgrade         > OS: aarch64-apple-darwin
 2022-09-22T09:57:22.274Z DEBUG topgrade         > Args { inner: ["topgrade", "-v", "--only", "emacs"] }
 2022-09-22T09:57:22.274Z DEBUG topgrade         > Binary path: Ok("/opt/homebrew/bin/topgrade")
 2022-09-22T09:57:22.274Z DEBUG topgrade         > Self Update: false
 2022-09-22T09:57:22.274Z DEBUG topgrade::utils  > Detected "/opt/homebrew/bin/git" as "git"
 2022-09-22T09:57:22.274Z DEBUG topgrade::utils  > Cannot find "doas"
 2022-09-22T09:57:22.274Z DEBUG topgrade::utils  > Detected "/usr/bin/sudo" as "sudo"
 2022-09-22T09:57:22.275Z DEBUG topgrade::utils  > Cannot find "pwsh"
 2022-09-22T09:57:22.275Z DEBUG topgrade::utils  > Cannot find "powershell"
 2022-09-22T09:57:22.275Z DEBUG topgrade::utils  > Path "/Users/ikaraszi/.config/emacs" doesn't exist
 2022-09-22T09:57:22.275Z DEBUG topgrade::utils  > Path "/Users/ikaraszi/.emacs.d" exists
 2022-09-22T09:57:22.275Z DEBUG topgrade::utils  > Path "/Users/ikaraszi/.emacs.d/bin/doom" exists
 2022-09-22T09:57:22.275Z DEBUG topgrade::steps::git > Checking if /Users/ikaraszi/.doom.d is a git repository
 2022-09-22T09:57:22.281Z TRACE topgrade::executor   > Output of "/opt/homebrew/bin/git" "rev-parse" "--show-toplevel": Output { status: ExitStatus(unix_wait_status(32768)), stdout: "", stderr: "fatal: not a git repository (or any of the parent directories): .git\n" }
 2022-09-22T09:57:22.281Z DEBUG topgrade::steps::git > /Users/ikaraszi/.ideavimrc does not exists
 2022-09-22T09:57:22.281Z DEBUG topgrade::steps::git > /Users/ikaraszi/.intellimacs does not exists
 2022-09-22T09:57:22.281Z DEBUG topgrade::steps::git > /Users/ikaraszi/.zshrc is a file. Checking /Users/ikaraszi
 2022-09-22T09:57:22.281Z DEBUG topgrade::steps::git > Checking if /Users/ikaraszi is a git repository
 2022-09-22T09:57:22.286Z TRACE topgrade::executor   > Output of "/opt/homebrew/bin/git" "rev-parse" "--show-toplevel": Output { status: ExitStatus(unix_wait_status(32768)), stdout: "", stderr: "fatal: not a git repository (or any of the parent directories): .git\n" }
 2022-09-22T09:57:22.286Z DEBUG topgrade::steps::git > /Users/ikaraszi/.config/fish does not exists
 2022-09-22T09:57:22.286Z DEBUG topgrade::steps::git > /Users/ikaraszi/Library/Application Support/openbox does not exists
 2022-09-22T09:57:22.286Z DEBUG topgrade::steps::git > /Users/ikaraszi/Library/Application Support/bspwm does not exists
 2022-09-22T09:57:22.286Z DEBUG topgrade::steps::git > /Users/ikaraszi/Library/Application Support/i3 does not exists
 2022-09-22T09:57:22.286Z DEBUG topgrade::steps::git > /Users/ikaraszi/Library/Application Support/sway does not exists
 2022-09-22T09:57:22.286Z DEBUG topgrade::runner     > Step "Emacs"
 2022-09-22T09:57:22.286Z DEBUG topgrade::utils      > Detected "/opt/homebrew/bin/emacs" as "emacs"

―― 11:57:22 - Summary ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
Emacs: SKIPPED: Path "/Users/ikaraszi/.emacs.d/init.el" doesn't exist
 2022-09-22T09:57:22.286Z DEBUG topgrade::terminal   > Desktop notification: Topgrade finished successfully
raszi commented 2 years ago

I have a Doom Emacs installed and working in ~/.emacs.d, but there are no init.el as the step requires only early-init.el. This was the commit when it was removed from Doom Emacs: https://github.com/doomemacs/doomemacs/commit/62ce9115e5fc1d06d0d0a4358619b223144946f2.

raszi commented 2 years ago

Of course the init.el does exist at ~/.doom.d/init.el.

raszi commented 2 years ago

964 might fix this issue

raszi commented 2 years ago

Closing since this is a duplicate of #961