PNPM update is skipped or fails

What did you expect to happen?

If pnpm is installed, to run pnpm up -g as the user (not as root).

What actually happened?

If there is no /usr/local/lib/node_modules (which, if you use pnpm instead of npm to install global packages, doesn't exist): npm: SKIPPED: NPM root at /usr/local/lib/node_modules doesn't exist
If that directory is arbitrarily created: npm: SKIPPED: NPM root is owned by another user which is not the current user. Set use_sudo = true under the NPM section in your configuration to run NPM as sudo
If use_sudo is set to true, pnpm cannot update as it operates in the user's home directory

This means that there is no way for topgrade update pnpm's global packages.

Per the logs (attached in details), even after it detects that pnpm exists, it runs npm root -g. It should instead run pnpm root -g as that correctly returns /home/$USER/.local/share/pnpm/global/5/node_modules.

Proposed Fix

Topgrade could possibly keep track of a variable such as node-package-manager, set it to npm by default, and if pnpm is detected, set it to pnpm instead. Any commands run, such as up or root would be run based on the package-manager. This might also simplify the logic in checking pnpm, as once the node-package-manager variable is set, all other commands can run agnostic to which package manager is actually being used (versus tracking pnpm as a seperate option, as seems to be done at a cursory glance at the code). This method would also allow easier support to other npm-compatible package managers that become popular in the future.

Additional Details

Which operating system or Linux distribution are you using? Fedora Linux 37
How did you install Topgrade? cargo install

Which version are you running? 9.0.1

❯ topgrade -v --only node --show-skipped
 2022-10-05T03:39:03.616Z DEBUG topgrade::config > No configuration exists
 2022-10-05T03:39:03.616Z DEBUG topgrade::config > Loaded configuration: ConfigFile { pre_commands: Some({}), post_commands: None, commands: Some({}), git_repos: None, predefined_git_repos: None, disable: None, ignore_failures: None, remote_topgrades: None, remote_topgrade_path: None, ssh_arguments: None, git_arguments: None, tmux_arguments: None, set_title: None, display_time: None, assume_yes: None, yay_arguments: None, no_retry: None, run_in_tmux: None, cleanup: None, notify_each_step: None, accept_all_windows_updates: None, bashit_branch: None, only: None, composer: Some(Composer { self_update: None }), brew: Some(Brew { greedy_cask: None }), linux: Some(Linux { yay_arguments: None, arch_package_manager: None, show_arch_news: None, trizen_arguments: None, pikaur_arguments: None, dnf_arguments: None, apt_arguments: None, enable_tlmgr: None, redhat_distro_sync: None, rpm_ostree: None, emerge_sync_flags: None, emerge_update_flags: None }), git: Some(Git { max_concurrency: None, arguments: None, repos: None, pull_predefined: None }), windows: Some(Windows { accept_all_updates: None, self_rename: None, open_remotes_in_new_terminal: None, enable_winget: None }), npm: Some(NPM { use_sudo: None }), vim: None, firmware: Some(Firmware { upgrade: None }), vagrant: None, flatpak: Some(Flatpak { use_sudo: None }) }
 2022-10-05T03:39:03.616Z DEBUG topgrade::utils  > Detected "/usr/bin/notify-send" as "notify-send"
 2022-10-05T03:39:03.616Z DEBUG topgrade         > Version: 9.0.1
 2022-10-05T03:39:03.616Z DEBUG topgrade         > OS: x86_64-unknown-linux-gnu
 2022-10-05T03:39:03.616Z DEBUG topgrade         > Args { inner: ["topgrade", "-v", "--only", "node", "--show-skipped"] }
 2022-10-05T03:39:03.616Z DEBUG topgrade         > Binary path: Ok("/home/ved/.cargo/bin/topgrade")
 2022-10-05T03:39:03.616Z DEBUG topgrade         > Self Update: false
 2022-10-05T03:39:03.616Z DEBUG topgrade::utils  > Detected "/usr/bin/git" as "git"
 2022-10-05T03:39:03.616Z DEBUG topgrade::utils  > Cannot find "doas"
 2022-10-05T03:39:03.616Z DEBUG topgrade::utils  > Detected "/usr/bin/sudo" as "sudo"
 2022-10-05T03:39:03.616Z DEBUG topgrade::utils  > Cannot find "pwsh"
 2022-10-05T03:39:03.616Z DEBUG topgrade::utils  > Cannot find "powershell"
 2022-10-05T03:39:03.616Z DEBUG topgrade::utils  > Path "/home/ved/.config/emacs" doesn't exist
 2022-10-05T03:39:03.616Z DEBUG topgrade::utils  > Path "/home/ved/.emacs.d" exists
 2022-10-05T03:39:03.616Z DEBUG topgrade::utils  > Path "/home/ved/.emacs.d/bin/doom" exists
 2022-10-05T03:39:03.616Z DEBUG topgrade::steps::git > /home/ved/.ideavimrc does not exists
 2022-10-05T03:39:03.616Z DEBUG topgrade::steps::git > /home/ved/.intellimacs does not exists
 2022-10-05T03:39:03.616Z DEBUG topgrade::steps::git > /home/ved/.zshrc does not exists
 2022-10-05T03:39:03.616Z DEBUG topgrade::steps::git > Checking if /home/ved/.config/fish is a git repository
 2022-10-05T03:39:03.617Z TRACE topgrade::executor   > Output of "/usr/bin/git" "rev-parse" "--show-toplevel": Output { status: ExitStatus(unix_wait_status(32768)), stdout: "", stderr: "fatal: not a git repository (or any parent up to mount point /)\nStopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).\n" }
 2022-10-05T03:39:03.617Z DEBUG topgrade::steps::git > /home/ved/.config/openbox does not exists
 2022-10-05T03:39:03.617Z DEBUG topgrade::steps::git > /home/ved/.config/bspwm does not exists
 2022-10-05T03:39:03.617Z DEBUG topgrade::steps::git > /home/ved/.config/i3 does not exists
 2022-10-05T03:39:03.617Z DEBUG topgrade::steps::git > Checking if /home/ved/.config/sway is a git repository
 2022-10-05T03:39:03.617Z TRACE topgrade::executor   > Output of "/usr/bin/git" "rev-parse" "--show-toplevel": Output { status: ExitStatus(unix_wait_status(32768)), stdout: "", stderr: "fatal: not a git repository (or any parent up to mount point /)\nStopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).\n" }
 2022-10-05T03:39:03.617Z DEBUG topgrade::runner     > Step "npm"
 2022-10-05T03:39:03.617Z DEBUG topgrade::utils      > Detected "/usr/bin/npm" as "npm"
 2022-10-05T03:39:03.617Z DEBUG topgrade::utils      > Detected "/home/ved/.local/share/pnpm/pnpm" as "pnpm"
 2022-10-05T03:39:03.862Z TRACE topgrade::executor   > Output of "/usr/bin/npm" "root" "-g": Output { status: ExitStatus(unix_wait_status(0)), stdout: "/usr/local/lib/node_modules\n", stderr: "" }

―― 23:39:03 - Summary ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
npm: SKIPPED: NPM root at /usr/local/lib/node_modules doesn't exist
 2022-10-05T03:39:03.862Z DEBUG topgrade::terminal   > Desktop notification: Topgrade finished successfully

r-darwish / topgrade