r-darwish / topgrade

Upgrade everything
GNU General Public License v3.0
3.35k stars 160 forks source link

No module named 'tldr' #821

Closed ghost closed 2 years ago

ghost commented 2 years ago

As with cargo-update not being installed it suggested:

cargo-update isn't installed so Topgrade can't upgrade cargo packages. Install cargo-update by running cargo install cargo-update

Regarding tldr it only show's the error and asks "retry yes no shell":

―― 16:58:33 - TLDR ―――――――――――――――――――――
Traceback (most recent call last):
  File "/usr/bin/tldr", line 5, in <module>
    from tldr import cli
ModuleNotFoundError: No module named 'tldr'

Retry? (y)es/(N)o/(s)hell

So it would be nice to install it or tell the user to install it with: "pip install tldr"

MCOfficer commented 2 years ago

That's weird, the TLDR step requires a tldr executable to be in $PATH. So you shouldn't see that step in the first place.

Can you check for that stray executable, or post the output with --verbose?

Edit: looking at it again, yes, you have /usr/bin/tldr, that's where the error originates from. But somehow that executable itself is failing. Not something topgrade needs to handle, imo.

r-darwish commented 2 years ago

Something is wrong with your installation of tldr. Either remove or reinstall it.