r-darwish / topgrade

Upgrade everything
GNU General Public License v3.0
3.36k stars 160 forks source link

Cannot find the vim -d binary required for viewing differences #842

Closed yochananmarqos closed 2 years ago

yochananmarqos commented 2 years ago

What did you expect to happen? vim should not be required for pacdiff. See #811

I have DIFFPROG set to meld in ~/.profile.

I had the pacdiff step disabled with 8.1.2 , but now that the option has been removed in 8.2.0 there doesn't appear to be a way to skip it anymore.

What actually happened?

 2022-01-24T17:49:42.539Z DEBUG topgrade::runner   > Step "config-update"
 2022-01-24T17:49:42.539Z DEBUG topgrade::utils    > Detected "/usr/bin/pacdiff" as "pacdiff"

―― 10:49:42 - Configuration update ―――――――――――――――――――――――――――――――――――――――――――――
 2022-01-24T17:49:42.539Z DEBUG topgrade::executor > Running "/usr/bin/sudo" "/usr/bin/pacdiff"
==> ERROR: Cannot find the vim -d binary required for viewing differences.
 2022-01-24T17:49:42.558Z DEBUG topgrade::runner   > Step "config-update" failed: exit status: 1
 2022-01-24T17:49:42.558Z DEBUG topgrade::terminal > Desktop notification: config-update failed

Additional details:

Run topgrade --dry-run to see which commands Topgrade is running. If the command seems wrong and you know why pleaes tell us so. If the command seems fine try to run it yourself and tell us if you got a different result from Topgrade.

 2022-01-24T18:02:40.303Z DEBUG topgrade::config > Configuration at /home/yochanan/.config/topgrade.toml
 2022-01-24T18:02:40.304Z DEBUG topgrade::config > Loaded configuration: ConfigFile { pre_commands: Some({}), post_commands: None, commands: Some({}), git_repos: None, predefined_git_repos: None, disable: Some([Cargo, Node, Pip3, Rustup]), ignore_failures: None, remote_topgrades: None, remote_topgrade_path: None, ssh_arguments: None, git_arguments: None, tmux_arguments: None, set_title: None, assume_yes: None, yay_arguments: None, no_retry: None, run_in_tmux: None, cleanup: None, notify_each_step: None, accept_all_windows_updates: None, bashit_branch: None, only: None, composer: Some(Composer { self_update: None }), brew: Some(Brew { greedy_cask: None }), linux: Some(Linux { yay_arguments: None, arch_package_manager: Some(Yay), show_arch_news: None, trizen_arguments: None, dnf_arguments: None, apt_arguments: None, enable_tlmgr: None, redhat_distro_sync: None, rpm_ostree: None, emerge_sync_flags: None, emerge_update_flags: None }), git: Some(Git { max_concurrency: None, arguments: None, repos: None, pull_predefined: None }), windows: Some(Windows { accept_all_updates: None, self_rename: None, open_remotes_in_new_terminal: None }), npm: Some(NPM { use_sudo: None }), vim: None, firmware: Some(Firmware { upgrade: None }), vagrant: None, flatpak: Some(Flatpak { use_sudo: None }) }
 2022-01-24T18:02:40.304Z DEBUG topgrade::utils  > Detected "/usr/bin/notify-send" as "notify-send"
 2022-01-24T18:02:40.304Z DEBUG topgrade         > Version: 8.2.0
 2022-01-24T18:02:40.304Z DEBUG topgrade         > OS: x86_64-unknown-linux-gnu
 2022-01-24T18:02:40.304Z DEBUG topgrade         > Args { inner: ["topgrade", "-v"] }
 2022-01-24T18:02:40.304Z DEBUG topgrade         > Binary path: Ok("/usr/bin/topgrade")
 2022-01-24T18:02:40.304Z DEBUG topgrade         > Self Update: false
 2022-01-24T18:02:40.304Z DEBUG topgrade::utils  > Detected "/usr/bin/git" as "git"
 2022-01-24T18:02:40.304Z DEBUG topgrade::utils  > Cannot find "doas"
 2022-01-24T18:02:40.304Z DEBUG topgrade::utils  > Detected "/usr/bin/sudo" as "sudo"
 2022-01-24T18:02:40.304Z DEBUG topgrade::utils  > Cannot find "pwsh"
 2022-01-24T18:02:40.304Z DEBUG topgrade::utils  > Cannot find "powershell"
 2022-01-24T18:02:40.304Z DEBUG topgrade::runner > Step "System update"

―― 11:02:40 - System update ――――――――――――――――――――――――――――――――――――――――――――――――――――
 2022-01-24T18:02:40.304Z DEBUG topgrade::utils  > Cannot find "powerpill"
 2022-01-24T18:02:40.304Z DEBUG topgrade::utils  > Detected "/usr/bin/yay" as "yay"
 2022-01-24T18:02:41.171Z DEBUG topgrade::executor > Running "/usr/bin/yay" "--pacman" "pacman" "-Syu" "--devel"
[sudo] password for yochanan: 
:: Synchronizing package databases...
 core is up to date
 extra is up to date
 community is up to date
 multilib is up to date
 xyne-x86_64 is up to date
 teejeetech-baqpaq is up to date
 teejeetech-lpt-service-manager is up to date
:: Starting full system upgrade...
warning: gnome-control-center-cosmic: local (41.2-3.99) is newer than extra (41.2-2)
warning: lutris: ignoring package upgrade (0.5.9.1-3 => 0.5.9.1-4)
warning: manjaro-chrootbuild: local (r237.g96d22f7-1.1) is newer than extra (r237.g96d22f7-1)
warning: python-yaml: local (6.0-0) is newer than community (5.4.1.1-4)
 there is nothing to do
:: Searching databases for updates...
:: Searching AUR for updates...
 -> gnome-control-center-cosmic: local (41.2-3.99) is newer than extra (41.2-2)
 -> lutris: ignoring package upgrade (0.5.9.1-3 => 0.5.9.1-4)
 -> manjaro-chrootbuild: local (r237.g96d22f7-1.1) is newer than extra (r237.g96d22f7-1)
 -> python-yaml: local (6.0-0) is newer than community (5.4.1.1-4)
:: Checking development packages...
 -> python-pychromecast: ignoring package upgrade (9.2.1-1 => 10.2.3-1)
 -> extension-manager: local (0.2.1-1) is newer than AUR (0.1.0-4)
 -> freetube: local (0.15.1.beta-1) is newer than AUR (0.15.1-1)
 -> ocs-url: local (3.1.0-8) is newer than AUR (3.1.0-7)
 -> python-tesserocr: local (2.5.2-1) is newer than AUR (2.5.1-1)
 -> timetrack: local (2.0.0-1) is newer than AUR (1.2.2.r0.gf273606-1)
 -> vizex: local (2.1.1c-1) is newer than AUR (2.0.3-2)
 -> Missing AUR Packages:  asp  cosmic-panel-git  cosmic-settings-git  findex  gedit-restore-tabs-git  gnome-shell-extension-brightness-git  keyboard-color-switcher-git  needrestart-session  playhouse-git  portproton  s76-keyboard-colors
 -> Flagged Out Of Date AUR Packages:  jdownloader2  libmysqlclient
 there is nothing to do
 2022-01-24T18:02:48.377Z DEBUG topgrade::runner   > Step "config-update"
 2022-01-24T18:02:48.377Z DEBUG topgrade::utils    > Detected "/usr/bin/pacdiff" as "pacdiff"

―― 11:02:48 - Configuration update ―――――――――――――――――――――――――――――――――――――――――――――
 2022-01-24T18:02:48.378Z DEBUG topgrade::executor > Running "/usr/bin/sudo" "/usr/bin/pacdiff"
==> ERROR: Cannot find the vim -d binary required for viewing differences.
 2022-01-24T18:02:48.396Z DEBUG topgrade::runner   > Step "config-update" failed: exit status: 1
 2022-01-24T18:02:48.396Z DEBUG topgrade::terminal > Desktop notification: config-update failed

Retry? (y)es/(N)o/(s)hell