search

r-darwish / topgrade

Upgrade everything
GNU General Public License v3.0
3.36k stars 160 forks source link

ArchLinux - pacdiff should not be run with `-y' command line #846

Closed duckunix closed 2 years ago

duckunix commented 2 years ago

What did you expect to happen? When passing the command line flag of -y, I would expect that all interactive commands are disabled if not able to run them without user input, this includes pacdiff by passing it the --output argument

What actually happened? pacdiff is called interactively and will sit and wait for input, breaking any automation around running topgrade

Additional details:

Relevant section of topgrade -y -v

―― 07:31:44 - Configuration update ―――――――――――――――――――――――――――――――――――――――――――――
 2022-01-26T13:31:44.838Z DEBUG topgrade::executor > Running "/usr/bin/doas" "/usr/bin/pacdiff"
==> pacnew file found for /etc/ImageMagick-7/policy.xml
:: (V)iew, (S)kip, (R)emove pacnew, (O)verwrite with pacnew, (Q)uit: [v/s/r/o/q]
duckunix commented 2 years ago

Thanks for the quick turn-around. I am afraid I do not know any rust, so I was no help beyond reporting the issue. :(