r-darwish / topgrade

Upgrade everything
GNU General Public License v3.0
3.36k stars 160 forks source link

Do not fail parsing config when a disabled step was not found #847

Closed xeruf closed 2 years ago

xeruf commented 2 years ago

As steps are added and changed, the ones one might to disable by default change, too. But when topgrade recognizes an unknown step to be disabled in the config-file, it not only warns, it stops parsing it altogether. This poses multiple issues, especially for setups where different topgrade versions are used across different systems with the same config file.

What did you expect to happen? topgrade may warn when there is an invalid step to be disabled from the config, but it should still disable all the other ones.

What actually happened? If a step is changed (such as pacdiff) or I disable a newly added step and run an older version of topgrade on another device with the same config, it resorts to running all steps.

Additional details:

r-darwish commented 2 years ago

Sorry, but I'm against this one. It's very rare to change a step's name.

xeruf commented 2 years ago

That may be true, but steps being added is not uncommon, and running software with the same config on both Debian stable and latest Arch is not uncommon. Is there any counterargument other than it not being a common usecase?