search

r-darwish / topgrade

Upgrade everything
GNU General Public License v3.0
3.35k stars 160 forks source link

On Windows every app is reinstalled even if they are already updated at latest version #872

Closed dnviti closed 2 years ago

dnviti commented 2 years ago

What did you expect to happen?

Upgrading applications when necessary

What actually happened?

All applications are reinstalled even if they are at their latest version, that could create unnecessary problems. Installed version is detected so it could only be a missing test.

Additional details

topgrade -v
 2022-03-15T18:52:32.720Z DEBUG topgrade::config > Configuration at C:\Users\dnvit\AppData\Roaming\topgrade.toml
 2022-03-15T18:52:32.720Z DEBUG topgrade::config > Loaded configuration: ConfigFile { pre_commands: Some({}), post_commands: None, commands: Some({}), git_repos: None, predefined_git_repos: None, disable: None, ignore_failures: None, remote_topgrades: None, remote_topgrade_path: None, ssh_arguments: None, git_arguments: None, tmux_arguments: None, set_title: None, assume_yes: None, yay_arguments: None, no_retry: None, run_in_tmux: None, cleanup: None, notify_each_step: None, accept_all_windows_updates: None, bashit_branch: None, only: None, composer: Some(Composer { self_update: None }), brew: Some(Brew { greedy_cask: None }), linux: Some(Linux { yay_arguments: None, arch_package_manager: None, show_arch_news: None, trizen_arguments: None, dnf_arguments: None, apt_arguments: None, enable_tlmgr: None, redhat_distro_sync: None, rpm_ostree: None, emerge_sync_flags: None, emerge_update_flags: None }), git: Some(Git { max_concurrency: None, arguments: None, repos: None, pull_predefined: None }), windows: Some(Windows { accept_all_updates: None, self_rename: None, open_remotes_in_new_terminal: None }), npm: Some(NPM { use_sudo: None }), vim: None, firmware: Some(Firmware { upgrade: None }), vagrant: None, flatpak: Some(Flatpak { use_sudo: None }) }
 2022-03-15T18:52:32.721Z DEBUG topgrade         > Version: 8.2.0
 2022-03-15T18:52:32.721Z DEBUG topgrade         > OS: x86_64-pc-windows-msvc
 2022-03-15T18:52:32.721Z DEBUG topgrade         > Args { inner: ["C:\\Users\\dnvit\\.cargo\\bin\\topgrade.exe", "-v"] }
 2022-03-15T18:52:32.721Z DEBUG topgrade         > Binary path: Ok("C:\\Users\\dnvit\\.cargo\\bin\\topgrade.exe")
 2022-03-15T18:52:32.721Z DEBUG topgrade         > Self Update: false
 2022-03-15T18:52:32.722Z DEBUG topgrade::utils  > Detected "C:\\Program Files\\Git\\cmd\\git.EXE" as "git"
 2022-03-15T18:52:32.725Z DEBUG topgrade::utils  > Cannot find "doas"
 2022-03-15T18:52:32.727Z DEBUG topgrade::utils  > Cannot find "sudo"
 2022-03-15T18:52:32.729Z DEBUG topgrade::utils  > Cannot find "gsudo"
 2022-03-15T18:52:32.731Z DEBUG topgrade::utils  > Cannot find "pkexec"
 2022-03-15T18:52:32.733Z DEBUG topgrade::utils  > Cannot find "pwsh"
 2022-03-15T18:52:32.734Z DEBUG topgrade::utils  > Detected "C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\powershell.EXE" as "powershell"
 2022-03-15T18:52:32.898Z TRACE topgrade::executor > Output of "C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\powershell.EXE" "-NoProfile" "-Command" "Split-Path $profile": Output { status: ExitStatus(ExitStatus(0)), stdout: "C:\\Users\\dnvit\\Documents\\WindowsPowerShell\r\n", stderr: "" }
 2022-03-15T18:52:32.899Z DEBUG topgrade::runner   > Step "WSL"
 2022-03-15T18:52:32.899Z DEBUG topgrade::utils    > Detected "C:\\Windows\\system32\\wsl.EXE" as "wsl"
 2022-03-15T18:52:36.444Z TRACE topgrade::executor > Output of "C:\\Windows\\system32\\wsl.EXE" "bash" "-lc" "which topgrade": Output { status: ExitStatus(ExitStatus(1)), stdout: "", stderr: "" }
 2022-03-15T18:52:36.444Z DEBUG topgrade::runner   > Step "Chocolatey"
 2022-03-15T18:52:36.447Z DEBUG topgrade::runner   > Step "Scoop"
 2022-03-15T18:52:36.449Z DEBUG topgrade::runner   > Step "Winget"
 2022-03-15T18:52:36.451Z DEBUG topgrade::utils    > Detected "C:\\Users\\dnvit\\AppData\\Local\\Microsoft\\WindowsApps\\winget.EXE" as "winget"

―― 19:52:36 - winget ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
 2022-03-15T18:52:36.454Z DEBUG topgrade::executor > Running "C:\\Users\\dnvit\\AppData\\Local\\Microsoft\\WindowsApps\\winget.EXE" "upgrade" "--all"
Found Discord [Discord.Discord] Version 1.0.9004
Found NAPS2 [Cyanfish.NAPS2] Version 6.1.2
Found Notepad++ [Notepad++.Notepad++] Version 8.3.2
Found ONLYOFFICE Desktop Editors [ONLYOFFICE.DesktopEditors] Version 7.0.1.37
Found Postman [Postman.Postman] Version 9.14.0
Found Spotify [Spotify.Spotify] Version 1.1.80.699.gc3dac750
Found Microsoft Teams [Microsoft.Teams] Version 1.5.00.4689
Found Microsoft Visual C++ 2013 Redistributable (x64) [Microsoft.VC++2013Redist-x64] Version 12.0.40664.0
Found Microsoft Build of OpenJDK with Hotspot 11 [Microsoft.OpenJDK.11] Version 11.0.14.101
Found Typora [Typora.Typora] Version 1.1.5
Found Nextcloud [Nextcloud.NextcloudDesktop] Version 3.4.3.20220225
Found Microsoft Visual Studio Code [Microsoft.VisualStudioCode] Version 1.65.2
Found Microsoft Visual C++ 2013 Redistributable (x86) [Microsoft.VC++2013Redist-x86] Version 12.0.40664.0
(1/13) Found Discord [Discord.Discord] Version 1.0.9004
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Successfully verified installer hash
Starting package install...
Successfully installed

(2/13) Found NAPS2 [Cyanfish.NAPS2] Version 6.1.2
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://github.com/cyanfish/naps2/releases/download/v6.1.2/naps2-6.1.2-setup.exe
  ██████████████████████████████  2.26 MB / 2.26 MB
Successfully verified installer hash
Starting package install...
Successfully installed

(3/13) Found Notepad++ [Notepad++.Notepad++] Version 8.3.2
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://github.com/notepad-plus-plus/notepad-plus-plus/releases/download/v8.3.2/npp.8.3.2.Installer.x64.exe
An unexpected error occurred while executing the command:
Download request status is not success.
0x80190194 : Not found (404).
 2022-03-15T18:52:57.306Z DEBUG topgrade::runner   > Step "Winget" failed: exit code: 0x80190194
 2022-03-15T18:52:57.307Z DEBUG topgrade::terminal > Desktop notification: Winget failed

Retry? (y)es/(N)o/(s)hell
 2022-03-15T18:52:58.763Z DEBUG topgrade::utils    > Path "C:\\Users\\dnvit\\AppData\\Roaming\\.emacs.d" doesn't exist
 2022-03-15T18:52:58.763Z DEBUG topgrade::steps::git > C:\Users\dnvit\.doom.d does not exists
 2022-03-15T18:52:58.763Z DEBUG topgrade::steps::git > C:\Users\dnvit\.vim does not exists
 2022-03-15T18:52:58.763Z DEBUG topgrade::steps::git > C:\Users\dnvit\.config/nvim does not exists
 2022-03-15T18:52:58.763Z DEBUG topgrade::steps::git > C:\Users\dnvit\.ideavimrc does not exists
 2022-03-15T18:52:58.763Z DEBUG topgrade::steps::git > C:\Users\dnvit\.intellimacs does not exists
 2022-03-15T18:52:58.764Z DEBUG topgrade::steps::git > Checking if \\?\C:\Users\dnvit\AppData\Local\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\LocalState is a git repository
 2022-03-15T18:52:58.764Z DEBUG topgrade::steps::git > Transformed path to C:\Users\dnvit\AppData\Local\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\LocalState
 2022-03-15T18:52:58.784Z TRACE topgrade::executor   > Output of "C:\\Program Files\\Git\\cmd\\git.EXE" "rev-parse" "--show-toplevel": Output { status: ExitStatus(ExitStatus(128)), stdout: "", stderr: "fatal: not a git repository (or any of the parent directories): .git\n" }
 2022-03-15T18:52:58.784Z DEBUG topgrade::runner     > Step "Git repositories"
 2022-03-15T18:52:58.785Z DEBUG topgrade::runner     > Step "apm"
 2022-03-15T18:52:58.787Z DEBUG topgrade::runner     > Step "fossil"
 2022-03-15T18:52:58.789Z DEBUG topgrade::runner     > Step "rustup"
 2022-03-15T18:52:58.791Z DEBUG topgrade::utils      > Detected "C:\\Users\\dnvit\\.cargo\\bin\\rustup.EXE" as "rustup"

―― 19:52:58 - rustup ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
 2022-03-15T18:52:58.795Z DEBUG topgrade::executor   > Running "C:\\Users\\dnvit\\.cargo\\bin\\rustup.EXE" "update"
info: syncing channel updates for 'stable-x86_64-pc-windows-msvc'
info: checking for self-updates

  stable-x86_64-pc-windows-msvc unchanged - rustc 1.59.0 (9d1b2106e 2022-02-23)

info: cleaning up downloads & tmp directories
 2022-03-15T18:52:59.049Z DEBUG topgrade::runner     > Step ".NET"
 2022-03-15T18:52:59.051Z DEBUG topgrade::utils      > Detected "C:\\Program Files\\dotnet\\dotnet.EXE" as "dotnet"

―― 19:52:59 - .NET ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
 2022-03-15T18:52:59.246Z DEBUG topgrade::executor   > Running "dotnet" "tool" "update" "electronnet.cli" "--global"
Tool 'electronnet.cli' was reinstalled with the latest stable version (version '13.5.1').
 2022-03-15T18:53:01.514Z DEBUG topgrade::runner     > Step "choosenim"
 2022-03-15T18:53:01.517Z DEBUG topgrade::runner     > Step "cargo"
 2022-03-15T18:53:01.517Z DEBUG topgrade::utils      > Path "C:\\Users\\dnvit\\.cargo" exists
 2022-03-15T18:53:01.519Z DEBUG topgrade::utils      > Detected "C:\\Users\\dnvit\\.cargo\\bin\\cargo.EXE" as "cargo"
 2022-03-15T18:53:01.519Z DEBUG topgrade::utils      > Path "C:\\Users\\dnvit\\.cargo\\.crates.toml" exists

―― 19:53:01 - Cargo ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
 2022-03-15T18:53:01.525Z DEBUG topgrade::utils      > Detected "C:\\Users\\dnvit\\.cargo\\bin\\cargo-install-update.EXE" as "cargo-install-update"
 2022-03-15T18:53:01.525Z DEBUG topgrade::executor   > Running "C:\\Users\\dnvit\\.cargo\\bin\\cargo-install-update.EXE" "install-update" "--git" "--all"
    Updating registry 'https://github.com/rust-lang/crates.io-index'

Package       Installed  Latest  Needs update
cargo-update  v8.1.2     v8.1.2  No
topgrade      v8.2.0     v8.2.0  No

No packages need updating.
Package  Installed  Latest  Needs update

No git packages need updating.
Overall updated 0 packages.
 2022-03-15T18:53:02.238Z DEBUG topgrade::runner     > Step "Flutter"
 2022-03-15T18:53:02.241Z DEBUG topgrade::runner     > Step "Go"
 2022-03-15T18:53:02.243Z DEBUG topgrade::runner     > Step "Emacs"
 2022-03-15T18:53:02.245Z DEBUG topgrade::runner     > Step "opam"
 2022-03-15T18:53:02.248Z DEBUG topgrade::runner     > Step "vcpkg"
 2022-03-15T18:53:02.250Z DEBUG topgrade::runner     > Step "pipx"
 2022-03-15T18:53:02.252Z DEBUG topgrade::runner     > Step "conda"
 2022-03-15T18:53:02.254Z DEBUG topgrade::runner     > Step "pip3"
 2022-03-15T18:53:02.256Z DEBUG topgrade::utils      > Detected "C:\\Users\\dnvit\\AppData\\Local\\Programs\\Python\\Python310\\Scripts\\pip3.EXE" as "pip3"

―― 19:53:02 - pip3 ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
 2022-03-15T18:53:02.260Z DEBUG topgrade::executor   > Running "C:\\Users\\dnvit\\AppData\\Local\\Programs\\Python\\Python310\\Scripts\\pip3.EXE" "install" "--upgrade" "--user" "pip"
Requirement already satisfied: pip in c:\users\dnvit\appdata\roaming\python\python310\site-packages (22.0.4)
 2022-03-15T18:53:03.497Z DEBUG topgrade::runner     > Step "stack"
 2022-03-15T18:53:03.500Z DEBUG topgrade::runner     > Step "tlmgr"
 2022-03-15T18:53:03.502Z DEBUG topgrade::runner     > Step "myrepos"
 2022-03-15T18:53:03.504Z DEBUG topgrade::runner     > Step "chezmoi"
 2022-03-15T18:53:03.506Z DEBUG topgrade::runner     > Step "jetpack"
 2022-03-15T18:53:03.509Z DEBUG topgrade::runner     > Step "vim"
 2022-03-15T18:53:03.511Z DEBUG topgrade::runner     > Step "Neovim"
 2022-03-15T18:53:03.513Z DEBUG topgrade::runner     > Step "voom"
 2022-03-15T18:53:03.515Z DEBUG topgrade::runner     > Step "npm"
 2022-03-15T18:53:03.517Z DEBUG topgrade::utils      > Detected "C:\\Program Files\\nodejs\\npm.CMD" as "npm"

―― 19:53:03 - Node Package Manager ―――――――――――――――――――――――――――――――――――――――――――――
 2022-03-15T18:53:03.521Z DEBUG topgrade::executor   > Running "C:\\Program Files\\nodejs\\npm.CMD" "update" "-g"

up to date, audited 1 package in 311ms

found 0 vulnerabilities
 2022-03-15T18:53:04.461Z DEBUG topgrade::runner     > Step "pnpm"
 2022-03-15T18:53:04.463Z DEBUG topgrade::runner     > Step "deno"
 2022-03-15T18:53:04.465Z DEBUG topgrade::runner     > Step "composer"
 2022-03-15T18:53:04.467Z DEBUG topgrade::runner     > Step "krew"
 2022-03-15T18:53:04.470Z DEBUG topgrade::runner     > Step "gem"
 2022-03-15T18:53:04.472Z DEBUG topgrade::runner     > Step "haxelib"
 2022-03-15T18:53:04.474Z DEBUG topgrade::runner     > Step "sheldon"
 2022-03-15T18:53:04.476Z DEBUG topgrade::runner     > Step "rtcl"
 2022-03-15T18:53:04.478Z DEBUG topgrade::runner     > Step "bin"
 2022-03-15T18:53:04.481Z DEBUG topgrade::runner     > Step "gcloud"
 2022-03-15T18:53:04.483Z DEBUG topgrade::runner     > Step "micro"
 2022-03-15T18:53:04.485Z DEBUG topgrade::runner     > Step "raco"
 2022-03-15T18:53:04.488Z DEBUG topgrade::runner     > Step "spicetify"
 2022-03-15T18:53:04.490Z DEBUG topgrade::runner     > Step "Windows update"
 2022-03-15T18:53:04.491Z DEBUG topgrade::utils      > Detected "C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\powershell.EXE" as "powershell"
 2022-03-15T18:53:04.618Z TRACE topgrade::executor   > Output of "C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\powershell.EXE" "-NoProfile" "-Command" "Get-Module -ListAvailable PSWindowsUpdate": Output { status: ExitStatus(ExitStatus(0)), stdout: "", stderr: "" }
 2022-03-15T18:53:04.618Z DEBUG topgrade::utils      > Detected "C:\\Windows\\system32\\UsoClient.EXE" as "UsoClient"

―― 19:53:04 - Windows Update ―――――――――――――――――――――――――――――――――――――――――――――――――――
Running Windows Update. Check the control panel for progress.
 2022-03-15T18:53:04.622Z DEBUG topgrade::executor   > Running "C:\\Windows\\system32\\UsoClient.EXE" "ScanInstallWait"
 2022-03-15T18:53:04.703Z DEBUG topgrade::executor   > Running "C:\\Windows\\system32\\UsoClient.EXE" "StartInstall"

―― 19:53:04 - Summary ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
WSL: SKIPPED: Could not find Topgrade installed in WSL
Chocolatey: SKIPPED: Cannot find "choco" in PATH
Scoop: SKIPPED: Cannot find "scoop" in PATH
Winget: FAILED
Git repositories: SKIPPED: No repositories to pull
apm: SKIPPED: Cannot find "apm" in PATH
fossil: SKIPPED: Cannot find "fossil" in PATH
rustup: OK
.NET: OK
choosenim: SKIPPED: Cannot find "choosenim" in PATH
cargo: OK
Flutter: SKIPPED: Cannot find "flutter" in PATH
Go: SKIPPED: Cannot find "go" in PATH
Emacs: SKIPPED: Cannot find "emacs" in PATH
opam: SKIPPED: Cannot find "opam" in PATH
vcpkg: SKIPPED: Cannot find "vcpkg" in PATH
pipx: SKIPPED: Cannot find "pipx" in PATH
conda: SKIPPED: Cannot find "conda" in PATH
pip3: OK
stack: SKIPPED: Cannot find "stack" in PATH
tlmgr: SKIPPED: Cannot find "tlmgr" in PATH
myrepos: SKIPPED: Cannot find "mr" in PATH
chezmoi: SKIPPED: Cannot find "chezmoi" in PATH
jetpack: SKIPPED: Cannot find "jetpack" in PATH
vim: SKIPPED: Cannot find "vim" in PATH
Neovim: SKIPPED: Cannot find "nvim" in PATH
voom: SKIPPED: Cannot find "voom" in PATH
npm: OK
pnpm: SKIPPED: Cannot find "pnpm" in PATH
deno: SKIPPED: Cannot find "deno" in PATH
composer: SKIPPED: Cannot find "composer" in PATH
krew: SKIPPED: Cannot find "kubectl-krew" in PATH
gem: SKIPPED: Cannot find "gem" in PATH
haxelib: SKIPPED: Cannot find "haxelib" in PATH
sheldon: SKIPPED: Cannot find "sheldon" in PATH
rtcl: SKIPPED: Cannot find "rupdate" in PATH
bin: SKIPPED: Cannot find "bin" in PATH
gcloud: SKIPPED: Cannot find "gcloud" in PATH
micro: SKIPPED: Cannot find "micro" in PATH
raco: SKIPPED: Cannot find "raco" in PATH
spicetify: SKIPPED: Cannot find "spicetify" in PATH
Windows update: OK
 2022-03-15T18:53:04.732Z DEBUG topgrade::terminal   > Desktop notification: Topgrade finished with errors
MCOfficer commented 2 years ago

Do you mean through winget? It's a known issue that winget misdetects local versions and thus thinks updates are necessary, but that isn't up to topgrade to fix.

dnviti commented 2 years ago

is there any way to solve this?

MCOfficer commented 2 years ago

None i know of. See https://github.com/microsoft/winget-cli/issues/1075

r-darwish commented 2 years ago

Winget has been disabled by default in version 8.3.0