search

r-darwish / topgrade

Upgrade everything
GNU General Public License v3.0
3.36k stars 161 forks source link

No 'failed step' notification #903

Closed jtrv closed 2 years ago

jtrv commented 2 years ago

notifications for the beginning of a step work, but notifications for a failed step do not appear to be working on my machine no-fail

r-darwish commented 2 years ago

https://github.com/r-darwish/topgrade/blob/336f529410a0c9c0fa884ea07f6fa3fa11428c0c/src/terminal.rs#L222

There's already a desktop notification when a step fails. Adding a notification when one succeeds seems redundant as you see the notification of the next step beginning. Aren't failure notifications displayed on your computer?

Notification for input would be awesome but I cannot think of any way to implement it.

jtrv commented 2 years ago

There's already a desktop notification when a step fails ... Aren't failure notifications displayed on your computer?

I do not get notifications when a step fails, only when a step starts. I didn't realize this was the intended default behavior, I will update the issue.

Notification for input would be awesome but I cannot think of any way to implement it.

Same, I'm not sure if it's possible but I mentioned it just in case someone else knows better.

jtrv commented 2 years ago

I've updated the issue and also attached a Gif to show the current behavior.