search

r-darwish / topgrade

Upgrade everything
GNU General Public License v3.0
3.37k stars 162 forks source link

Improve winget support on by default skip unknown versions #928

Closed MANICX100 closed 2 years ago

MANICX100 commented 2 years ago

I want to suggest some general feature

Topgrade should have winget enabled by default for windows hosts BUT skip packages of unknown version to avoid constantly redownloading existing versions.

More information

A script implementing this behavior is available here: https://gist.github.com/Nejat/6cb42f098320cb2fcb57a4e1728ca29e

Thanks @najat

r-darwish commented 2 years ago

Seems like a lot of logic to implement in Topgrade so I'm debating whether the best thing to do is to embed this script inside it. @Najat since this script has no license attached, may I have your permission to embed it inside Topgrade?

r-darwish commented 2 years ago

I put some further thinking about this and got to the conclusion that even if we have some sort of solution, I won't make WInget turned on by default because it's a built-in tool in Windows that many don't want to use. In addition to that, I think it's out of scope for Topgrade to do so much to deal with the fact that Winget's upgrade command has a really weird behavior. Winget needs to be fixed by it's maintainers before it's on by default in Topgrade.