r-darwish / topgrade

Upgrade everything
GNU General Public License v3.0
3.37k stars 162 forks source link

Performant Node Package Manager - No package.json found #938

Closed bingalls closed 2 years ago

bingalls commented 2 years ago

What did you expect to happen?

Topgrade should normally finish without errors

What actually happened?

Performant Node Package Manager  ERROR  No package.json found

Additional details

Dry running: $HOME/.nvm/versions/node/v16.14.0/bin/npm update -g ―― - Performant Node Package Manager Dry running: $HOME/.nvm/versions/node/v16.14.0/bin/pnpm update -g

That's right, after npm upgrades all global libs, pnpm tries to repeat its work and fails!

Paste the output of `topgrade -v`

The problem is with pnpm. Topgrade already runs npm, so it is not faster. pnpm expects package.json in the current directory, even when I run Topgrade from my home directory. pnpm is not installed via Homebrew. If I uninstall it, Topgrade re-installs it, potentially restarting this problem. I cannot seem to hack a package.json in multiple locations to squelch this error. pnpm is a great tool that provides no value to Topgrade

Solution: remove pnpm process from Topgrade.

r-darwish commented 2 years ago

@SilentVoid13 - can you please advise?