r-darwish / topgrade

Upgrade everything
GNU General Public License v3.0
3.37k stars 162 forks source link

Trim go paths #940

Closed r-darwish closed 2 years ago

r-darwish commented 2 years ago

@jtsagata can you please check this branch?

MCOfficer commented 2 years ago

Files and directories can technically end in whitespace, so there's the extremely unlikely scenario that this will break go updates for users who have their gopath set to, say ~/mygo

Edit: Seems like github strips whitespace as well. Oh well

jtsagata commented 2 years ago

It's working as expected with the trimming.

Now, if my $GOPATH, or any directory, ends with space, I will expect much more Sirius problems than this :-). Maybe just remove a trailing `\n;