r-darwish / topgrade

Upgrade everything
GNU General Public License v3.0
3.37k stars 162 forks source link

Add yarn support. Fix #958 #963

Open 0xMRTT opened 2 years ago

0xMRTT commented 2 years ago

Standards checklist:

If you developed a feature or a bug fix for someone else and you do not have the means to test it, please tag this person here.

Fix issue #958 from @nicks-passiert

nicks-passiert commented 2 years ago

Thank you @0xMRTT, can't wait to use it!

r-darwish commented 2 years ago

Is this reasonable to run both npm and yarn? Do they have different sets of installed packages?

nicks-passiert commented 1 year ago

For me it is enough if I can choose if I use npm or yarn. For me there are no use cases where I would run both at the same time.

0xMRTT commented 1 year ago

Okay, so we can add a new parameter to npm which is the path to the command for updating. By default it will be npm but you can change for yarn.

What do you think ?

MCOfficer commented 1 year ago

The alternative is to do what topgrade already does for things like nala/apt: If tool X is a drop-in replacement designed to replace tool Y, and tool X is installed, run X instead of Y. In this case, yarn instead of npm.

0xMRTT commented 1 year ago

The alternative is to do what topgrade already does for things like nala/apt: If tool X is a drop-in replacement designed to replace tool Y, and tool X is installed, run X instead of Y. In this case, yarn instead of npm.

But if you have yarn and npm, maybe you need to choose

nicks-passiert commented 1 year ago

Both would be for me good. Maybe it would be good to choose, to have a solution for the most users.

nicks-passiert commented 1 year ago

I tested it on MacOS and it works for me

nicks-passiert commented 1 year ago

What is to do, to get this done here?

MCOfficer commented 1 year ago

What is to do, to get this done here?

afaict roey is just gone for a bit. Gotta wait for them to come back.

s34m commented 1 year ago

Merged at new fork because of inactivity by maintainer.

0xMRTT commented 1 year ago

Oh, what about creating an org for that ?

s34m commented 1 year ago

Oh, what about creating an org for that ?

Will be done in the future, currently in the progress of just looking at current issues and PRs

0xMRTT commented 1 year ago

I'll be glad to help you

s34m commented 1 year ago

Oh, what about creating an org for that ?

Here it is: https://github.com/topgrade-rs/topgrade