search

r-darwish / topgrade

Upgrade everything
GNU General Public License v3.0
3.35k stars 160 forks source link

Fix Doom upgrade command #968

Open reinaldoossuna opened 2 years ago

reinaldoossuna commented 2 years ago

fix #960

xeruf commented 2 years ago

Please also detect early-init.el next to init.el, otherwise it ignores doom - or did you already fix that?

reinaldoossuna commented 2 years ago

I don't check for an init.el or early-init.el if the system has doom emacs.

line 82

if let Some(doom) = &self.doom {
    Emacs::update_doom(doom, ctx)
} else {
    let init_file = require_option(self.directory.as_ref(), String::from("Emacs directory does not exist"))?
    ....
xeruf commented 2 years ago

LET SOME DOOM SELF DOOM

reads kinda funny, anyways, good to know, thank you :)

vmalloc commented 1 year ago

Hi @reinaldoossuna - can you please rebase this PR so that we can review and merge it? Also it seems there are still outstanding comments here that need to be addressed