r-dbi / DBItest

Testing DBI drivers
http://dbitest.r-dbi.org
GNU Lesser General Public License v2.1
24 stars 17 forks source link

Introduce "strict" mode for `bigint` setting #334

Open nbenn opened 9 months ago

nbenn commented 9 months ago

Commit 641ec8b on branch dev for adbi adds experimental support for "strict" bigint options: "integer-strict" and "numeric-strict" both error on lossy data conversions (due to overflow or rounding).

Using "integer-strict" as default causes issues with tests:

Further issues might exist but currently do not reach the point where this issue comes up. Candidates include

krlmlr commented 9 months ago

Thanks for the heads-up, looks good!

We should expand the specs here. It will take some time because I want to inline the checks first. The skips in adbi are fine for now, except I don't see why arrow_read_table_arrow would fail.