Closed d-hansen closed 4 weeks ago
Aviator will automatically update this comment as the status of the PR changes. Comment
/aviator refresh
to force Aviator to re-examine your PR (or learn about other/aviator
commands).
This pull request is currently open (not queued).
To merge this PR, comment /aviator merge
or add the mergequeue
label.
Thanks for the super-quick fix. How can we test this in CI/CD?
mariadb-libs-5.5.68 is still generally available: https://rpmfind.net/linux/RPM/centos/7.9.2009/x86_64/Packages/mariadb-libs-5.5.68-1.el7.x86_64.html I'm not sure what system you are using to host your CI/CD, but probably just make an docker container that includes that version of the MariaDb libraries.
FYI: this archive includes the -devel package: https://archive.mariadb.org/mariadb-5.5.68/yum/rhel/6Server/x86_64/rpms/
Well, I see you run Ubuntu 22.04. So, here is a link you can download MariaDb 5.5.68 for a systemd-based Linux: https://archive.mariadb.org/mariadb-5.5.68/bintar-linux-systemd-x86_64/mariadb-5.5.68-linux-systemd-x86_64.tar.gz That's the full server enchilada, so should be more than enough to test with. Probably just make a copy of this environment "ubuntu-22.04 (release) MariaDB server + client" but use the above link for the install of MariaDB.
Thanks. I want to add old MariaDB to CI/CD before merging this.
@BillWeld: Can you please confirm that this PR works for you?
I don’t know how to grab that version. I can specify releases by git tag if there’s a tag you can point me to.
On Jul 1, 2024, at 4:50 PM, Kirill Müller @.***> wrote:
Thanks. I want to add old MariaDB to CI/CD before merging this.
@BillWeld https://github.com/BillWeld: Can you please confirm that this PR works for you?
— Reply to this email directly, view it on GitHub https://github.com/r-dbi/RMariaDB/pull/338#issuecomment-2200997389, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUGAOFO6W4YTKPIYAMLXTTZKG6LBAVCNFSM6AAAAABKGE4EFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBQHE4TOMZYHE. You are receiving this because you were mentioned.
@BillWeld: Can you please
install_github("r-dbi/RMariaDB#338")
or
install_github("d-hansen/RMariaDB")
?
Will do. On Jul 7, 2024, at 4:22 PM, Kirill Müller @.***> wrote: @BillWeld: Can you please install_github("r-dbi/RMariaDB#338") or install_github("d-hansen/RMariaDB") ?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>
Both build cleanly.
Thanks, Rob
On Jul 7, 2024, at 4:22 PM, Kirill Müller @.***> wrote:
@BillWeld https://github.com/BillWeld: Can you please
install_github("r-dbi/RMariaDB#338") or
install_github("d-hansen/RMariaDB") ?
— Reply to this email directly, view it on GitHub https://github.com/r-dbi/RMariaDB/pull/338#issuecomment-2212560447, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUGAOBHXEDKI6CO6FO6XG3ZLGPPFAVCNFSM6AAAAABKGE4EFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSGU3DANBUG4. You are receiving this because you were mentioned.
Hey, I noticed this PR is still outstanding. Any update on merging it? Anything you need from me?
Thanks. Taking care of the failing builds in #344.
Thanks, also for the nudge!
Add back SSL support for MariaDb 5.5.68 which seems to be the default MariaDB version in AWS AL2 base.
Note: AWS AL2 will be deprecated and replaced by AL2023 in June 2025. Note2: At some point in the future, I would expect some version of MariaDB (> 11) to follow suit with MySQL 8 and switch to using the
MYSQL_OPT_SSL_MODE
instead ofMYSQL_OPT_SSL_ENFORCE
to enable SSL.Closes #336.