search

r-dbi / RPostgres

A DBI-compliant interface to PostgreSQL
https://rpostgres.r-dbi.org
Other
334 stars 78 forks source link

chore: Windows: update to libpq-15.3 #442

Closed jeroen closed 12 months ago

jeroen commented 12 months ago

This also adds support for ARM, which CRAN is going to support soon.

jeroen commented 12 months ago

I think this is good to merge. The Windows compiler warning is pre-existing and is triggered by your vendored boost, and is unrelated to this PR:

Found the following significant warnings:
  vendor/boost/intrusive/detail/slist_node.hpp:56:16: warning: pointer used after 'void operator delete(void*, std::size_t)' [-Wuse-after-free]
  vendor/boost/intrusive/detail/hook_traits.hpp:77:10: warning: pointer used after 'void operator delete(void*, std::size_t)' [-Wuse-after-free]
krlmlr commented 12 months ago

Good catch regarding this warning. Is this a g++12 bug? I could update the vendored headers to see if it goes away, but I wonder if an Rtools update is pending that will upgrade GCC.

krlmlr commented 12 months ago

Thanks. It's great to have these warnings appear in CI/CD too 😊 . The same warnings are seen on CRAN, so perhaps not worth holding our breath.

jeroen commented 12 months ago

Yes I think it is a bug in gcc-12. It is fixed in gcc-13. I can suggest a hack if you like.

krlmlr commented 12 months ago

A hack would be great, thanks!

jeroen commented 12 months ago

OK here you go: https://github.com/r-dbi/RPostgres/pull/443