r-dbi / RPostgres

A DBI-compliant interface to PostgreSQL

https://rpostgres.r-dbi.org

Other

328 stars 78 forks source link

chore: Move libpq underneath `src/` on Windows #447

Closed krlmlr closed 8 months ago

krlmlr commented 8 months ago

Fixes warnings on Windows, I wonder why I don't see them on CRAN.

aviator-app[bot] commented 8 months ago

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was closed without merging. If you still want to merge this PR, re-open it.

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

jeroen commented 8 months ago

Fixes warnings on Windows, I wonder why I don't see them on CRAN.

Some files get left behind when building the source package on Windows. For the CRAN version, the source package was built by you on linux/mac, and only the binaries get built on Windows.

I prefer this solution: https://github.com/r-dbi/RPostgres/pull/449