Website code is difficult to read in dark mode

r-dbi / RSQLite

R interface for SQLite

https://rsqlite.r-dbi.org

GNU Lesser General Public License v2.1

327 stars 79 forks source link

Open jonbry opened 2 weeks ago

jonbry commented 2 weeks ago

Not sure if this is the right place to post this, but I noticed that the website is a bit difficult to read if the computer is set to dark mode:

For comparison, here's an example of pkgdown's website, which is much easier to read:

I had no issue if I switched my computer/phone to light mode.

krlmlr commented 2 weeks ago

Thanks. What browser do you use? This looks okay to me in Firefox's Dark Mode Reader, but certainly could be improved.

CC @maelle.

jonbry commented 2 weeks ago

What browser do you use?

Thanks for the quick reply! The screenshots are of Firefox (Ubuntu). I got the same results on Safari for both iOS and macOS.

It looks like the main page is ok, but the Articles and References might be different. Here's what I see for Write a local data frame or file to database with Safari (iOS):

krlmlr commented 2 weeks ago

Looks good on Firefox, terrible on Safari, on my machine. I wonder what's going on.

maelle commented 1 week ago

maelle commented 1 week ago

I'm realizing that dbitemplate does not provide dark mode, let me fix that.

maelle commented 1 week ago