r-dbi / odbc

Connect to ODBC databases (using the DBI interface)
https://odbc.r-dbi.org/
Other
387 stars 107 forks source link

move [R] warnings out of destructor path #797

Closed detule closed 3 months ago

detule commented 4 months ago

Hi Team:

Just following up on a discussion where @hadley pointed out we should avoid Rcpp::warning in the destructor path as an error there, as a result of options(warn>2), and the subsequent longjmp, could lead to incorrect resource unwind.

Moving the warning up to the [R] frame.