search

r-devel / r-bug-tracking-lesson

Carpentries-style Lesson on R’s Bug Tracking Process
http://contributor.r-project.org/r-bug-tracking-lesson/
Other
5 stars 4 forks source link

[FEATURE] add solutions to the output blocks #14

Open amangoel185 opened 2 years ago

amangoel185 commented 2 years ago

Add all the solutions in amangoel185/feat/solutions/fig to the corresponding output sections for the Exploring R's Bugzilla chapter. It can be done in two steps:

hturner commented 2 years ago

Thanks @amangoel185. Do you want to make a PR just adding the screenshots in episodes/figures/ for now? That might make it easier to test adding them to the solutions. Would that work for you @SaranjeetKaur?

I haven't tried, but maybe knitr::include_graphics() would help in adding them to the solutions.

SaranjeetKaur commented 2 years ago

It would be better to keep the fig folder independent and not within the episodes folder. Because the episodes folder is supposed to include only the .Rmd files, I think - let me check though!

On Fri, Apr 8, 2022, 17:14 Heather Turner @.***> wrote:

Thanks @amangoel185 https://github.com/amangoel185. Do you want to make a PR just adding the screenshots in episodes/figures/ for now? That might make it easier to test adding them to the solutions. Would that work for you @SaranjeetKaur https://github.com/SaranjeetKaur?

I haven't tried, but maybe knitr::include_graphics() would help in adding them to the solutions.

— Reply to this email directly, view it on GitHub https://github.com/r-devel/r-bug-tracking-lesson/issues/14#issuecomment-1092774916, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGZ32SAFNOQ72UCPIDTCAZ3VEALYDANCNFSM5S2GUYEQ . You are receiving this because you were mentioned.Message ID: @.***>

zkamvar commented 2 years ago

It would be better to keep the fig folder independent and not within the episodes folder. Because the episodes folder is supposed to include only the .Rmd files, I think - let me check though!

Actually, the episodes folder contains all content needed for rendering the episodes, so the figures, data, and any supplemental files should go inside the episodes folder.

This makes the episodes folder self-contained. It's also nice because learners can take the episodes folder and successfully run the RMarkdown documents independently of the overall lesson structure.

zkamvar commented 2 years ago

You can see how it's set up in: https://github.com/carpentries/sandpaper-docs/tree/main/episodes

SaranjeetKaur commented 2 years ago

Oh ok, thanks for sharing that!

On Sat, Apr 9, 2022, 05:58 Zhian N. Kamvar @.***> wrote:

You can see how it's set up in: https://github.com/carpentries/sandpaper-docs/tree/main/episodes

— Reply to this email directly, view it on GitHub https://github.com/r-devel/r-bug-tracking-lesson/issues/14#issuecomment-1093519916, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGZ32SCHVHMW6L62QIQ3OI3VEDFLFANCNFSM5S2GUYEQ . You are receiving this because you were mentioned.Message ID: @.***>

amangoel185 commented 2 years ago

Sure, I'll add the solutions to episodes/fig then, and we can look into the linking after that!