search

r-devel / r-project-sprint-2023

Material for the R project sprint
https://contributor.r-project.org/r-project-sprint-2023/
17 stars 3 forks source link

Project: Dendrapply Refactor #29

Open hturner opened 1 year ago

hturner commented 1 year ago

Discussed in https://github.com/r-devel/r-project-sprint-2023/discussions/6

Originally posted by **giscus[bot]** June 30, 2023 # R Project Sprint 2023 - Dendrapply Refactor https://contributor.r-project.org/r-project-sprint-2023/projects/dendrapply-refactor/
ahl27 commented 1 year ago

Code is updated and working at https://github.com/ahl27/new_dendrapply

Changes are mostly with regard to documentation and streamlining. The R code for this is significantly reduced without breaking functionality, and the backend C code has a lot of comments added to it. This implementation is tested and working on internal R checks and all of the tests in dendextend; larger CRAN checks are still a work in progress. Working on making an updated patch and adding all of this to the original bugzilla report (https://bugs.r-project.org/show_bug.cgi?id=18480).

Edit: A new patch is available on the original bugzilla report (https://bugs.r-project.org/show_bug.cgi?id=18480). Result of checks on building R is available at https://github.com/r-devel/r-svn/pull/111. This version is around 5x faster on balanced trees with the added benefit of being non-recursive.

aitap commented 10 months ago

As of 10th of October, the patch is on v6, waiting for another round of review and fixes.