Open hturner opened 1 year ago
Code is updated and working at https://github.com/ahl27/new_dendrapply
Changes are mostly with regard to documentation and streamlining. The R code for this is significantly reduced without breaking functionality, and the backend C code has a lot of comments added to it. This implementation is tested and working on internal R checks and all of the tests in dendextend
; larger CRAN checks are still a work in progress. Working on making an updated patch and adding all of this to the original bugzilla report (https://bugs.r-project.org/show_bug.cgi?id=18480).
Edit: A new patch is available on the original bugzilla report (https://bugs.r-project.org/show_bug.cgi?id=18480). Result of checks on building R is available at https://github.com/r-devel/r-svn/pull/111. This version is around 5x faster on balanced trees with the added benefit of being non-recursive.
As of 10th of October, the patch is on v6, waiting for another round of review and fixes.
Discussed in https://github.com/r-devel/r-project-sprint-2023/discussions/6