r-devel / rdevguide

A guide for contributing to R core development
https://contributor.r-project.org/rdevguide/
Other
60 stars 19 forks source link

Update 02-getting_started.Rmd #137

Closed itsdebartha closed 1 year ago

itsdebartha commented 1 year ago

Fixed:

llrs commented 1 year ago

Thanks for the PR, I missed the link to rtools42 when I changed it to Rtools43.

We added the quotations to ensure a proper variable substitution. Can you check that the paths will work with users with spaces (aka $USER == "Mister Bean"?

hturner commented 1 year ago

Yes, the quotations were deliberate, to address issues where users have spaces in the path. I think you can fix the issue by changing

"/c/Program\ Files/MiKTeX/miktex/bin/x64:$PATH"

to

"/c/Program Files/MiKTeX/miktex/bin/x64:$PATH"

itsdebartha commented 1 year ago

That looks good, in fact better... I have changed the commit...

llrs commented 1 year ago

Thanks! I merged it.

hturner commented 1 year ago

@all-contributors please add @itsdebartha for content please add @llrs for review please add @hturner for review

allcontributors[bot] commented 1 year ago

@hturner

I've put up a pull request to add @itsdebartha! :tada:

@llrs already contributed before to review

@hturner already contributed before to review