search

r-devel / translations-dashboard

Dashboard to monitor status of translations in R
https://contributor.r-project.org/translations-dashboard
8 stars 6 forks source link

Try not to depend on stringr #9

Open benubah opened 2 years ago

benubah commented 2 years ago

do we know where this script will be run? if it's run on server/in Docker/somehow deployed, I would recommend using base R regex. stringr brings stringi which in my experience is quite a heavy dependency.

OTOH, if this script will only be run manually / locally, using stringr will be fine :)

_Originally posted by @MichaelChirico in https://github.com/r-devel/translations/pull/5#discussion_r931779574_

koduu commented 1 month ago

I started with a refactor, seems feasible enough, though the performance most certainly takes a slight hit. I am currently doing the fixes into a forked version (https://github.com/koduu/translations-dashboard), will talk with @hturner to see how to get it merged to the main repo later on