search

r-devel / translations

subsite for translations
https://contributor.r-project.org/translations/
Creative Commons Attribution 4.0 International
1 stars 3 forks source link

Add recommended packages #2

Closed hturner closed 1 year ago

hturner commented 1 year ago

Currently Weblate only covers base packages, we could consider adding recommended packages.

I guess the logistics are more difficult as they have different maintainers and the source is different places. We could start with the ones maintained on the R Project SVN (https://svn.r-project.org/R-packages/trunk/) and/or packages whose maintainers are at the sprint.

mmaechler commented 1 year ago

Definitely. They have "always" received translations and translation updates in the past.

MichaelChirico commented 1 year ago

Summarizing discussion with @daroczig and @lawremi today:

There are three basic approaches here:

  1. Put each Recommended package in its own project
  2. Make one new project for all the Recommended packages
  3. Put all the Recommended packages inside the existing project as new components

I think there are two drawbacks to 1 and 2:

There are two drawbacks to 3 as well:

On balance, I think 3 is the best choice. I will add the components tomorrow & work out the script for generating multiple patches.

hturner commented 1 year ago

I would be more in favour of Option 2.

Response to drawbacks:

More pros of Option 2:

If you still think Option 3 is better (easier to maintain), it would be good if Recommended packages could be clearly marked in some way and perhaps ordered together when looking at the list of components (perhaps after everything maintained by R Core).

MichaelChirico commented 1 year ago

Sounds good, thanks Heather! I'm swayed -- we'll do a project for recommended packages.

MichaelChirico commented 1 year ago

List of components to add:

MichaelChirico commented 1 year ago

lattice has a faulty .po file; Weblate error here:

Could not parse 1 matched file. lattice/po/R-de.po: end-of-line within string on line 176: 'msgid "Invalid key, need at least one component named lines, text, rect or points"\n'

@deepayan could you help to apply the following patch to lattice/po/R-de.po:

msgid "Invalid key, need at least one component named lines, text, rect or points"
-msgstr 
+msgstr ""
"Ungültiger Schlüssel. Es wird mindestens eine Komponente mit Namen "
"»lines«, »text«, »rect« oder »points« benötigt."
MichaelChirico commented 1 year ago

Update at lunch: finished all packages maintained on the main SVN repo (except for lattice, which has an error).

MichaelChirico commented 1 year ago

Update from Deepayan: lattice is not maintained on that SVN repo, but GitHub:

https://github.com/deepayan/lattice

The other packages' sources may also be outdated there if the DESCRIPTION URL does not match.

MichaelChirico commented 1 year ago

The following packages are linked to the github cran mirror as a source since I'm not aware of a public source control for them:

~* Actually, Matrix is on R Forge, but Weblate doesn't support the SCM system.~

Gergely pointed out R Forge has an SVN source, we point to that now.

MichaelChirico commented 1 year ago

OK, recommended packages are available for translation:

https://translate.rx.studio/projects/the-r-project-recommended-packages/

One potential avenue for improvement: {lattice} and {rpart} are maintained on GitHub; we might consider setting up a workflow similar to that done for the Mac GUI files whereby we set up the push configuration to send patches directly as PRs to the upstream maintainers.

MichaelChirico commented 1 year ago

Marking this as closed. Let's open follow-up issues as needed for announcing/communicating the new components, and more quality-of-life improvements on this project as needed.