r-geoflow / geoflow

Tools to Orchestrate Geospatial (Meta)Data Management Workflows and Manage FAIR Services
https://github.com/r-geoflow/geoflow/wiki
Other
41 stars 14 forks source link

Edition and EditionDate automatically added to XML #105

Closed juliepierson closed 3 years ago

juliepierson commented 3 years ago

Both elements get automatically added : <gmd:edition><gco:CharacterString>2021-01-28T15:01:24</gco:CharacterString></gmd:edition> <gmd:editionDate><gco:CharacterString>2021-01-28T15:59:24</gco:CharacterString></gmd:editionDate> These elements must be manually removed if not needed, or if needed CharacterString must be replaced with DateTime.

eblondel commented 3 years ago

Two things here:

As both deal with mapping the geoflow metadata model with ISO 19115, this is really an open discussion so @juliepierson @mrouan @wheintz @juldebar your opinion/vote is welcome before I proceed with changes

mrouan commented 3 years ago

I vote for :

eblondel commented 3 years ago

ok, thanks, @juldebar @wheintz what do you think?

eblondel commented 3 years ago

@mrouan @juliepierson i've implemented the above proposal. let me know if it works well on your side.

juldebar commented 3 years ago

I am not sure about the definition of "edition". My understanding is that it indicates the version of the metadata sheet and the content is free (doesn't have to be a date). If it is the case, it's arbitrary to put it either in one column or another. "Description" is a good option, "Identifier" might be another if we follow the same approach as the one used to version DOIs with one identifier per version.

eblondel commented 3 years ago

We have to distinguish 2 things:

juliepierson commented 3 years ago

Thank you ! We just tested :

eblondel commented 3 years ago

Can you re-install and check now?

Note aside: the ISO 19139 validation doesn't target the codelists you use. The standard gives default recommended values, but you are free to define your own codelist items (and your own vocabularies), the ISO 19139 will be valid. INSPIRE might say a different thing.

juliepierson commented 3 years ago

Wow, that's quick ! I retested, but and still get created when only publication:2021-03-04 is present in Date column of CSV. Thanks !

eblondel commented 3 years ago

Make sure Rstudio is restarted, the latter might run a cached version of past geoflow.

juliepierson commented 3 years ago

You're right, I forgot once again. All good now, thanks !!

eblondel commented 3 years ago

Great! :-)