Relative paths (data sources, local actions) in Data do not work

[AmandineHenon]

Pour lier des data en local, il faut noter le chemin absolu et non le chemin relatif !

[eblondel]

Could send me an example of your data column to see how it is structured?

I also need to know if it was run on ubuntu or windows os, and what was your working directory ( see getwd() ) when you run this workflow.

Thanks in advance

Le mer. 6 oct. 2021 à 08:42, AmandineHenon @.***> a écrit :

Pour lier des data en local, il faut noter le chemin absolu et non le chemin relatif !

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/eblondel/geoflow/issues/222, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKDK3D64TXTJRSFAIVLXMLUFPVUTANCNFSM5FNUXKAA .

[AmandineHenon]

@EmilieLerigoleur could probably give you the example we have worked on as it was on her computer.

[EmilieLerigoleur]

Hre is the example: source:S073.xlsx@/home/ahenon/test-indores/S073.xlsx sourceType:other uploadType:other_ upload:true

Thanks to @AmandineHenon to give your OS and version. Thanks to @wheintz to give the R version.

[AmandineHenon]

OS ; Windows 10

[eblondel]

The example of @EmilieLerigoleur sounds a Unix one...

[EmilieLerigoleur]

If I remember correctly the test, we needed to move the data file in the repository of the R server (managed by Wil). The path here is effectively a Unix one because I imagine the R server is installed on a Unix OS. The problem is not the OS. The problem is that it is needed to put the absolute path, not the relative one. The documentation should mention that particularity. Moreover the documentation should precise that the "local path" is the path of the file in the R server machine. In other words, it is impossible to use file from our computer and a R server in another VM. Hope I am clear!

[eblondel]

Implementation should include:

• [x] plug a util function is_absolute_path to check whether a resource is on absolute / relative path
• [x] use this function in geoflow_entity$copyDataToJobDir in the case of local files handling (to fix the initial bug report)
• [x] use this function in geoflow_data to handle properly local action scripts, whatever their path
• [x] make sure that the local action scripts handling also distinguish the case of remote scripts with the appropriate regexp (see https://github.com/eblondel/geoflow/blob/master/R/geoflow_entity.R#L449)

[eblondel]

@EmilieLerigoleur @AmandineHenon could you reinstall geoflow and test this? It should be fixed now. Thanks