Closed eblondel closed 1 year ago
Are the global custom actions not concerned by this update ? As it still mandatory to have an "options" argument in the function ? (Line 517 of geoflow::initWorkflow https://github.com/eblondel/geoflow/blob/master/R/initWorkflow.R)
All actions should be concerned by this code refactoring/harmonization
Relates to #261 This is the current status regarding the way actions can be interfaced:
function
interface like:where
my_fun
should be the action id.This is highly criticizable and not really convenient for the user, for multiple reasons detailed below:
id
defined for the action.options
are not clear, especially for testing local actions, these are the action options. This 'argument' should be removed from the function interface. Theaction
definition should be made available. From there, options will be easily grab usingaction$options
, or using util to develop in #261 which will then avoid re-writing action options default values in the action function, but inherit them from the action definition;Hence, any action (global embedded, global custom, local) will have to be designed within a function interface as follows:
In addition, for global embedded actions, an attempt will be made to create a separate folder 'actions' under the 'inst' folder
@abennici @juldebar @wheintz if you have any questions, feel free. I will anyway assist you in changes where needed