r-geoflow / geoflow

Tools to Orchestrate Geospatial (Meta)Data Management Workflows and Manage FAIR Services
https://github.com/r-geoflow/geoflow/wiki
Other
40 stars 14 forks source link

Entity type is not well decoded with `generic` key is explicitely set #373

Closed IRDnamik closed 8 months ago

IRDnamik commented 8 months ago

I've encountered errors uploading a parent metadata record with a zip on zenodo:

[zen4R][ERROR] ZenodoRecord - The upload type should be among the values [publication,poster,presentation,dataset,image,video,software,lesson,physicalobject,other]

I initially thought that the problem came from a structural error in the DATA column, but after many test, the problem seems to come from the "Type" column which was defined as generic:dataset as it appears by default in the documentation.

By replacing generic:dataset with "other" I no longer get any errors and the file is now correctly transmitted to zenodo.

geoflow version: 0.20230801 config.json

eblondel commented 8 months ago

Thanks, i reproduced the issue. It's not related to Zenodo, but to the decoding of the entity tabular handler that doesn't detect the generic key (default) if explicitely specified. It's a bug

eblondel commented 8 months ago

@IRDnamik can you reinstall and retest specifying generic:dataset? It should work now. The generic is the default key it can be omitted, but if set it should work in the same way (what i fixed now)

IRDnamik commented 8 months ago

@eblondel I will try the correction when zenodo will be available again (this afternoon hopefully)

eblondel commented 8 months ago

Since this is independent from Zenodo. I would suggest you simply try to load a workflow with config = initWorkflow("your workflow") and you then look at the identifiers attached to the entity you had listed in your table, with config$metadata$content$entities[[1]]$identifiers$id. If you get a value "dataset" instead of "generic:dataset", it means it's solved.