r-hub / containers

Docker containers for R-hub
https://r-hub.github.io/containers/
15 stars 4 forks source link

Provide intel-2024 container #68

Closed krlmlr closed 3 months ago

krlmlr commented 3 months ago

We're seeing weird errors in duckdb and igraph regarding get_temporary_buffer():

These don't reproduce in the existing intel container which has the 2023.2 compiler:

Can we upgrade the compiler, or should this be a new container?

gaborcsardi commented 3 months ago

Yeah, we should update the version.

gaborcsardi commented 3 months ago

Sadly, the container is too big now, an we can't build it on GHA: https://github.com/r-hub/containers/actions/runs/9792014055/job/27036965641#step:7:2135

gaborcsardi commented 3 months ago

I fixed the build, so the new container is now deployed.

krlmlr commented 3 months ago

Thanks, running now:

krlmlr commented 3 months ago

Curious, what did you do to fix the build? Wipe out even more on the GHA machine?

krlmlr commented 3 months ago

This still seems to use 2023.2.1? What am I doing wrong?

https://github.com/duckdb/duckdb-r/actions/runs/9834536464/job/27146520243#step:4:509

I ran:

rhub::rhub_check(platforms = rhub::rhub_platforms()$name, branch = "cran-1.0.0-1")
gaborcsardi commented 3 months ago

Curious, what did you do to fix the build? Wipe out even more on the GHA machine?

Yeah.

This still seems to use 2023.2.1? What am I doing wrong?

Ah, the image has now multiple compilers, and the old one is the default. Fixing now.

gaborcsardi commented 3 months ago

@krlmlr OK, try again now, it seems to be good now: https://r-hub.github.io/containers/containers.html#intel