search

r-hub / cranlogs

Download Logs from the RStudio CRAN Mirror
https://r-hub.github.io/cranlogs/
Other
79 stars 13 forks source link

last-week, last-month vs. last 7 days, last 30 days #22

Closed ghost closed 6 years ago

ghost commented 7 years ago

As it seems the values last-week, last-month of the when argument are really meant to mean last 7 days and last 30 days, respectively. Given the current names, one could suspect to get the last full week (Mon - Sun) and the last full month (1 to 28, 29, 30, or 31 days).

Thus, my suggestion is to introduce more explicit names (last-7-days, last-30-days), maybe additionally (and discourage use of last-week, last-month but allow for them as back-compatiblilty).

gaborcsardi commented 6 years ago

Sorry, I will not do that. I think that you are right, but I also think that it is not worth changing it at this point.