r-hub / cranlogs

Download Logs from the RStudio CRAN Mirror
https://r-hub.github.io/cranlogs/
Other
79 stars 13 forks source link

Return data as a tibble #59

Closed bryceroney closed 3 years ago

bryceroney commented 3 years ago

This is a bit of a stylistic preference but my understanding is that tibbles are now preferred to data.frames.

This PR:

No dramas if you prefer data frames though

gaborcsardi commented 3 years ago

Thanks! Strictly speaking, this is a breaking change, because tibbles behave slightly different than data frames, so I think I will not merge this now.

It is easy to call tibble::as_tibble() on the result.

If we started today, then we would probably use tibbles.

bryceroney commented 3 years ago

Fair enough.