Mail says PREPERROR but build log says SUCCESS

r-hub / rhub

R-hub API client

https://r-hub.github.io/rhub/

Other

353 stars 52 forks source link

Mail says PREPERROR but build log says SUCCESS #445

Closed baktoft closed 6 months ago

baktoft commented 3 years ago

First off, thanks for this awesome tool! However, I am getting mixed signals on some of my runs. As subject indicates, I get different results for the same build in mail vs build log. See images below. Full build log available here: https://builder.r-hub.io/status/yaps_1.2.2.9003.tar.gz-e8f306bd41a24d90a1921d46ff0c8d48

Any advice will be highly appreciated. Thanks, \hb

gaborcsardi commented 3 years ago

Yes, that is misleading indeed. PREPERROR means that R-hub could not run the tests, probably because some dependency failed to install. Look at the detailed logs to see what exactly happened.

baktoft commented 3 years ago

Indeed it seems to be missing 'devtools' and 'xml2' for installing 'vdiffr'.

I have 'vdiffr' in DESCRIPTION Suggests and use if(requireNamespace("vdiffr", quietly = TRUE)){ ...tests...} for these particular tests. Furthermore, I am using rhub::check_for_cran(env_vars = c('_R_CHECK_FORCE_SUGGESTS_' = "false")) when checking on r-hub.

Is there anything I can do to fix this?

gaborcsardi commented 3 years ago

Check in the log why they failed to install.

gaborcsardi commented 3 years ago

Yeah, xml2 does not compile, I am not sure why.

baktoft commented 3 years ago

It seems to boil down to xml2 failing to install.

Additionally, devtools report missing dependencies roxygen2 and rversions - both of these in turn depends on xml2.

gaborcsardi commented 3 years ago

In any case, this container is somewhat old, so let me try to update it.

baktoft commented 3 years ago

Thanks! While you are at it, rhub/ubuntu-gcc-release seems to need an update too. On this, xml2 and openssl fails to install.

TNonet commented 3 years ago

Hi,

I seem to be facing a very similar issue.

I submitted a "rhub::check_with_sanitizers()" test to rhub this morning. After a few minutes, I received this in an email, but the logs (https://builder.r-hub.io/status/L0Learn_2.0.2.tar.gz-d7ff3723487940dfa2a77d0bbdb1d6b7) say "success".

However, when I search for "error" in this log file (to see if there is a dependency issue), the only errors seem to be at the end when rhub/docker is attempting to remove files.

If anyone has any advice or insights into this issue, it would be greatly appreciated.

A wonderful tool!

gaborcsardi commented 3 years ago

@TNonet your issue is the same as #448 I think, and it is indeed a bug.

SimonDedman commented 9 months ago

Throwing a +1 on the pile:

Build success and only 1 match to "ERROR" during find-in-page,

L1060: echo R_REMOTES_NO_ERRORS_FROM_WARNINGS=true

gaborcsardi commented 6 months ago

This issue is about the previous R-hub system, it does not apply to the new system, so I am closing it now. Please see https://r-hub.github.io/rhub/ for the new system, R-hub v2.