search

r-hub / rhub

R-hub API client
https://r-hub.github.io/rhub/
Other
353 stars 51 forks source link

package passes rhub platform check but fails CRAN #489

Closed alyssarosemartin closed 4 months ago

alyssarosemartin commented 2 years ago

Hello,

I am trying to figure out why our package (rnpn) fails CRAN, for fedora-clang-devel (CRAN report) but passes rhub::check_for_cran(platforms = "fedora-clang-devel")

Report 1 - when our DEV geoserver (which the tests hit) is up: https://builder.r-hub.io/status/rnpn_1.2.2.tar.gz-c12bbc2769244eb29f57abe5d4dc8fe6

Report 2 - when our DEV geoserver is down: https://builder.r-hub.io/status/rnpn_1.2.2.tar.gz-4e3f185e0219400f9c4e9fe4a8263fdd

(it also passes rhub::check_for_cran with no issue)

Grateful for any suggestions/directions to try!

gaborcsardi commented 2 years ago

It only failed on a single CRAN machine, so it is either specific to that machine, or it was a random one-off failure. E.g. maybe your web API returned something unexpected.

You could skip the test cases that need the internet on CRAN, because they often cause trouble.

alyssarosemartin commented 2 years ago

Thank you!!

Is there something in the report that shows you it only failed one machine? Or like - just the one platform/env? We had a similar failure last month (CRAN Report).. issues with linux and the geoserver calls.. so makes sense what you are saying- to limit those (skipping, or more use of VCR).

Our whole package is basically an API wrapper.. so, I'm unsure about how much testing to skip! But, that seems like more like a question for us, or for CRAN than for you - appreciate your help!

gaborcsardi commented 2 years ago

Is there something in the report that shows you it only failed one machine?

Click on "check results archive" at https://cran.rstudio.com/web/packages/rnpn/ It seems to me that this is the latest one.

I would skip all API tests on CRAN, and would use GitHub Actions or another CI instead.

gaborcsardi commented 4 months ago

This issue is about the previous R-hub system, it does not apply to the new system, so I am closing it now. Please see https://r-hub.github.io/rhub/ for the new system, R-hub v2.