r-hub / rhub

R-hub API client
https://r-hub.github.io/rhub/
Other
353 stars 51 forks source link

Consistency: Plural/Singular in platform argument #497

Closed datawookie closed 2 years ago

datawookie commented 2 years ago

Hi!

Love this package. But just noticed an inconsistency:

It seems that the latter is more appropriate since rhub::check() accepts a vector of values for platform. Is this intentional?

I'd be happy to fix this and create a PR. Just wanted to check first whether this was a design decision.

Thanks, Andrew.

gaborcsardi commented 2 years ago

They both accept vectors, actually, and yeah, it is not great that they are not consistent. Strictly speaking this would be a breaking change, but I think we can fix it, and change it to platforms in check().

This way if people have code that uses platform, it will still work with partial matching.

Thank you for the PR offer. :)