search

r-hub / rhub

R-hub API client
https://r-hub.github.io/rhub/
Other
353 stars 52 forks source link

Failed to use C++11 in Debian Linux, R-devel, GCC ASAN/UBSAN builder #516

Closed ntamas closed 2 years ago

ntamas commented 2 years ago

I'm preparing a new release for igraph and as part of the release I tried to enforce that the project is compiled with C++11 as some parts of the underlying C library now require C++11. I'm not sure whether I'm doing something wrong or the builder is misconfigured, but it looks like the "Debian Linux, R-devel, GCC ASAN/UBSAN builder" still uses C++98. See the build log here; in particular, look at this line, which seems to indicate that-std=gnu++11 is appended to CXX properly. Still, when it comes to compiling something, the build process uses -std=gnu++98; see this line.

Is this a bug in the builder, or am I doing something wrong?

gaborcsardi commented 2 years ago

See here: https://cran.r-project.org/doc/manuals/R-exts.html#Using-C_002b_002b-code

You need to add 

CXX_STD = CXX11

to the Makevars file(s), or 

SystemRequirements: C++11

to DESCRIPTION.

ntamas commented 2 years ago

Thanks, the CXX_STD=CXX11 part was missing; now it seems to work. Sorry for the false alarm.